TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 7 Projects Releases 1 Activity Actions

[#600] adm/tests: Add missing WaitGroup.Add() #601

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:adm-race into master 2023-08-11 09:50:10 +00:00
Conversation 0 Commits 1 Files changed 1 +1
fyrchik commented 2023-08-11 09:13:58 +00:00
Owner
Copy link
panic: sync: negative WaitGroup counter

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Closes #600

``` panic: sync: negative WaitGroup counter ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com> Closes #600
fyrchik added 1 commit 2023-08-11 09:14:10 +00:00
[#600] adm/tests: Add missing WaitGroup.Add()
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 10m13s
Details
Build / Build Components (1.21) (pull_request) Successful in 12m24s
Details
Build / Build Components (1.20) (pull_request) Successful in 13m46s
Details
Tests and linters / Staticcheck (pull_request) Successful in 16m2s
Details
Tests and linters / Tests (1.21) (pull_request) Failing after 19m12s
Details
Tests and linters / Tests (1.20) (pull_request) Failing after 21m0s
Details
Tests and linters / Lint (pull_request) Successful in 21m47s
Details
Tests and linters / Tests with -race (pull_request) Failing after 22m17s
Details
f28c32c74f 
```
panic: sync: negative WaitGroup counter
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
ale64bit approved these changes 2023-08-11 09:15:45 +00:00
fyrchik merged commit abdb0910cc into master 2023-08-11 09:50:10 +00:00
fyrchik deleted branch adm-race 2023-08-11 09:50:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#601
No description provided.
Delete branch "fyrchik/frostfs-node:adm-race"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?