[#574] Check if the container has been really removed from neo-go #624
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#624
Loading…
Reference in a new issue
No description provided.
Delete branch "aarifullin/frostfs-node:fix/574-tree_del_info"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -455,1 +467,3 @@
removed = append(removed, cnr)
existed, err := s.containerEverExisted(cnr)
if err != nil {
@fyrchik
I am not sure that this can be incorrectly ignored (the container cannot be appended to
removed
list and thus sync will try to sync the container?). Anyway, the netmap cannot be updated until we cannot get info about the containerHow is netmap update connected to all this?
It is right, not to remove container in case "unknown" error happens.
Sorry, nevermind
I have mistaken
newMap
fornetmap
:)bf5f39dc9a
to27fbce90f7
27fbce90f7
tode6245414f
Check if the container has been really removed from neo-goto [#574] Check if the container has been really removed from neo-go@ -16,1 +16,4 @@
container.Source
// DeletionInfo returns deletion info for the given container in the
// FrostFS network at the moment of a call.
at the moment of a call
is somewhat obvious (and, probably, doesn't say what you wanted to). How about to get rid of it?This was comment for a comment :) Removed
de6245414f
to14511cae0e
@ -443,0 +446,4 @@
if err == nil {
return true, nil
}
if errors.Is(err, &apistatus.ContainerNotFound{}) {
I am not sure
Is
will work now as expected (compared toAs
), do we useIs
anywhere for status errors?@ -443,0 +446,4 @@
if err == nil {
return true, nil
}
if errors.Is(err, &apistatus.ContainerNotFound{}) {
I am not sure
Is
will work now as expected (compared toAs
), do we useIs
anywhere for status errors?Sorry, some ideas "mixed" up in my mind.
Fixed to
errors.As
14511cae0e
toff04a1f5ad
ff04a1f5ad
to23be3eb627