TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 95 Pull requests 4 Projects Releases 1 Activity Actions

WIP: Add semgrep #628

Closed
achuprov wants to merge 1 commit from achuprov/frostfs-node:semgrep into master
pull from: achuprov/frostfs-node:semgrep
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 3 +34
achuprov commented 2023-08-21 13:25:51 +00:00
Member
Copy link

Prototype for using semgrep in frostfs-node. Currently, it doesn't check any useful rules.
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Prototype for using semgrep in frostfs-node. Currently, it doesn't check any useful rules. Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov changed title from Add semgrep to WIP: Add semgrep 2023-08-21 13:26:01 +00:00
fyrchik reviewed 2023-08-21 17:19:20 +00:00
Makefile Outdated
@ -163,2 +163,4 @@
@staticcheck ./...
semgrep-install:
python3 -m pip install semgrep
fyrchik commented 2023-08-21 17:19:20 +00:00
Owner
Copy link

Please, no.
Polluting global pip is bad (at lest if unexpected), we can use sth like virtualenv here.

Please, no. Polluting global `pip` is bad (at lest if unexpected), we can use sth like virtualenv here.
achuprov force-pushed semgrep from aac79d88f3 to 9d2999327e 2023-08-22 14:38:56 +00:00 Compare
fyrchik added the
discussion
Infrastructure
 labels 2023-12-07 14:59:44 +00:00
fyrchik commented 2023-12-07 14:59:50 +00:00
Owner
Copy link

While I like the tool, instalation process seems like a hassle.
Having just a single rule doesn't justify the complexity IMO, so let's close this PR.

While I like the tool, instalation process seems like a hassle. Having just a single rule doesn't justify the complexity IMO, so let's close this PR.
fyrchik closed this pull request 2023-12-07 14:59:50 +00:00
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 2m7s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 3m28s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 3m26s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m48s
Required
Details
DCO action / DCO (pull_request) Successful in 4m39s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m1s
Required
Details
Tests and linters / Lint (pull_request) Successful in 5m19s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m26s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 11m37s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#628
No description provided.
Delete branch "achuprov/frostfs-node:semgrep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?