TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

policer: Add "bad" testcase #673

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/656-add-test-notfound into master 2023-09-06 08:05:01 +00:00
Conversation 0 Commits 1 Files changed 4 +49 -25
acid-ant commented 2023-09-04 09:04:45 +00:00
Member
Copy link

Close #656

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #656 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2023-09-04 09:04:54 +00:00
acid-ant requested review from storage-core-developers 2023-09-04 09:05:05 +00:00
fyrchik approved these changes 2023-09-04 12:44:45 +00:00
pkg/services/policer/check.go Outdated
@ -41,3 +32,1 @@
zap.Stringer("cid", idCnr),
zap.Stringer("oid", idObj),
zap.String("error", err.Error()))
errFromBuryFn := p.buryFn(ctx, addrWithType.Address)
fyrchik commented 2023-09-04 12:43:13 +00:00
Owner
Copy link

Why did you rename the error?

Why did you rename the error?
acid-ant commented 2023-09-04 14:19:43 +00:00
Author
Member
Copy link

To keep error from p.cnrSrc.Get(idCnr).

To keep error from `p.cnrSrc.Get(idCnr)`.
fyrchik commented 2023-09-05 06:21:26 +00:00
Owner
Copy link

I don't understand -- it is not used in this branch.

I don't understand -- it is not used in this branch.
acid-ant commented 2023-09-05 06:30:15 +00:00
Author
Member
Copy link

See your point, revert these changes.

See your point, revert these changes.
fyrchik marked this conversation as resolved
pkg/services/policer/policer_test.go Outdated
@ -247,2 +248,3 @@
p.processObject(context.Background(), addrWithType)
err := p.processObject(context.Background(), addrWithType)
require.Nil(t, err)
fyrchik commented 2023-09-04 12:38:45 +00:00
Owner
Copy link

require.NoError?

`require.NoError`?
acid-ant commented 2023-09-04 14:23:07 +00:00
Author
Member
Copy link

Updated.

Updated.
fyrchik marked this conversation as resolved
pkg/services/policer/policer_test.go Outdated
@ -257,0 +278,4 @@
}
err := p.processObject(context.Background(), addrWithType)
require.True(t, client.IsErrContainerNotFound(err))
fyrchik commented 2023-09-04 12:40:57 +00:00
Owner
Copy link

Fine, but we still don't check whether buryFn was called this way -- we could easily call it and return an error.

Fine, but we still don't check whether `buryFn` was called this way -- we could easily call it and return an error.
acid-ant commented 2023-09-04 14:43:17 +00:00
Author
Member
Copy link

Agree, I added a few lines to test buryFn.

Agree, I added a few lines to test `buryFn`.
fyrchik marked this conversation as resolved
acid-ant force-pushed bugfix/656-add-test-notfound from aedf932266 to 41cff79351 2023-09-04 14:22:42 +00:00 Compare
acid-ant force-pushed bugfix/656-add-test-notfound from 41cff79351 to a51519654f 2023-09-04 14:41:34 +00:00 Compare
aarifullin approved these changes 2023-09-04 15:55:11 +00:00
aarifullin left a comment
Member
Copy link

Thanks!

Thanks!
fyrchik reviewed 2023-09-05 06:23:35 +00:00
pkg/services/policer/policer_test.go Outdated
@ -257,0 +296,4 @@
WithBuryFunc(buryFn),
)
require.ErrorIs(t, p.processObject(context.Background(), addrWithType), fromBury)
fyrchik commented 2023-09-05 06:23:31 +00:00
Owner
Copy link

That is useful, but not what I meant (I believe we already test this in a neighbour test.
In the first test we check the error, but do not check whether buryFn was called. It could be called, we must ensure it was not.

That is useful, but not what I meant (I believe we already test this in a neighbour test. In the first test we check the error, but do not check whether `buryFn` was called. It _could_ be called, we must ensure it was not.
acid-ant commented 2023-09-05 06:44:06 +00:00
Author
Member
Copy link

Gotcha, added buryFn in init, removed redundant test.

Gotcha, added `buryFn` in `init`, removed redundant test.
fyrchik marked this conversation as resolved
acid-ant force-pushed bugfix/656-add-test-notfound from a51519654f to e2dc220b60 2023-09-05 06:29:31 +00:00 Compare
acid-ant force-pushed bugfix/656-add-test-notfound from e2dc220b60 to 9f4effc74f 2023-09-05 06:43:07 +00:00 Compare
fyrchik approved these changes 2023-09-06 08:03:20 +00:00
fyrchik approved these changes 2023-09-06 08:04:10 +00:00
fyrchik merged commit 88d50e4c77 into master 2023-09-06 08:05:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#673
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/656-add-test-notfound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?