node: Fix header source creation when checking eacl #678

acid-ant · 2023-09-06T14:08:50Z

acid-ant commented

2023-09-06 14:08:50 +00:00

Applicable for PutSingle request.

Close #676

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Applicable for `PutSingle` request. Close #676 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant added 1 commit 2023-09-06 14:08:52 +00:00

[#676 ] node: Fix header source creation when checking eacl

DCO action / DCO (pull_request) Successful in 2m55s

Details

Build / Build Components (1.20) (pull_request) Successful in 4m53s

Details

Vulncheck / Vulncheck (pull_request) Successful in 4m36s

Details

Tests and linters / Staticcheck (pull_request) Successful in 6m35s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 7m7s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 7m47s

Details

Tests and linters / Tests with -race (pull_request) Failing after 10m7s

Details

Build / Build Components (1.21) (pull_request) Successful in 11m3s

Details

Tests and linters / Lint (pull_request) Successful in 17m34s

Details

aeeb8193d2

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers

2023-09-06 14:09:23 +00:00

fyrchik reviewed 2023-09-06 14:20:28 +00:00

pkg/services/object/acl/eacl/v2/headers.go

					
				@ -137,6 +137,8 @@ func (h *cfg) readObjectHeadersFromRequestXHeaderSource(m requestXHeaderSource,

							dst.objectHeaders = headersFromObject(objectSDK.NewFromV2(oV2), h.cnr, h.obj)

						}

					case *objectV2.PutSingleRequest:

fyrchik commented

2023-09-06 14:20:28 +00:00

Do we have existing tests where we can easily add a new testcase?

fyrchik approved these changes 2023-09-06 14:20:30 +00:00

fyrchik merged commit aeeb8193d2 into master

2023-09-06 15:10:26 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#678

Rows
Columns