TrueCloudLab
/
frostfs-node
19
1
Fork 21
Code Issues 88 Pull Requests 8 Actions 4 Releases Activity

WIP: [#706] morph: Use backoff strategy for UnsubscribeAll() #707

Closed
aarifullin wants to merge 1 commits from aarifullin/frostfs-node:fix/unsubcribe-all into support/v0.37
pull from: aarifullin/frostfs-node:fix/unsubcribe-all
merge into: TrueCloudLab:support/v0.37
Conversation 0 Commits 1 Files Changed 7
aarifullin commented 2023-09-26 19:31:49 +00:00
Collaborator
  • Sometimes the morph client cannot unsubscribe from events
    because websocket client may be got down and neo-go will
    never the request for unsubscription.

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Sometimes the morph client cannot unsubscribe from events because websocket client may be got down and neo-go will never the request for unsubscription. Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added the
discussion
 label 2023-09-26 19:31:49 +00:00
aarifullin added 1 commit 2023-09-26 19:31:53 +00:00
DCO action / DCO (pull_request) Successful in 2m42s Details
Build / Build Components (1.20) (pull_request) Successful in 4m26s Details
Tests and linters / Staticcheck (pull_request) Successful in 4m12s Details
Tests and linters / Lint (pull_request) Successful in 4m43s Details
Vulncheck / Vulncheck (pull_request) Successful in 4m58s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 5m8s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m23s Details
Tests and linters / Tests with -race (pull_request) Successful in 7m14s Details
Build / Build Components (1.21) (pull_request) Successful in 9m15s Details
04ab939e4c [#706] morph: Use backoff strategy for UnsubscribeAll() 
* Sometimes the morph client cannot unsubscribe from events
  because websocket client may be got down and neo-go will
  never the request for unsubscription.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2023-09-26 19:32:58 +00:00
aarifullin requested review from storage-core-developers 2023-09-26 19:32:58 +00:00
aarifullin changed title from [#706] morph: Use backoff strategy for UnsubscribeAll() to WIP: [#706] morph: Use backoff strategy for UnsubscribeAll() 2023-09-26 23:00:04 +00:00
aarifullin closed this pull request 2023-10-16 08:26:36 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 2m42s
Details
Build / Build Components (1.20) (pull_request) Successful in 4m26s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m12s
Details
Tests and linters / Lint (pull_request) Successful in 4m43s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m58s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 5m8s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m23s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m14s
Details
Build / Build Components (1.21) (pull_request) Successful in 9m15s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#707
There is no content yet.
Delete Branch "aarifullin/frostfs-node:fix/unsubcribe-all"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?