Fix delete container signature check #745

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/remove_container_debugee into master 2023-10-19 15:12:49 +00:00

Committed invalid condition, it was just for debug.

Committed invalid condition, it was just for debug.
dstepanov-yadro requested review from storage-core-committers 2023-10-19 15:03:40 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-10-19 15:03:41 +00:00
dstepanov-yadro reviewed 2023-10-19 15:04:46 +00:00
@ -68,3 +68,3 @@
// If TryNotary is provided, calls notary contract.
func (c *Client) Delete(p DeletePrm) error {
if len(p.signature) == 0 && p.IsControl() {
if len(p.signature) == 0 && !p.IsControl() {
Author
Member

When IsControl == true, then len(p.signature) == 0, because there is no container owner signature.

When IsControl == true, then len(p.signature) == 0, because there is no container owner signature.
fyrchik approved these changes 2023-10-19 15:05:45 +00:00
acid-ant approved these changes 2023-10-19 15:06:21 +00:00
dstepanov-yadro force-pushed fix/remove_container_debugee from 1c0b5c3767 to dc4d27201b 2023-10-19 15:08:12 +00:00 Compare
dstepanov-yadro merged commit dc4d27201b into master 2023-10-19 15:12:49 +00:00
dstepanov-yadro deleted branch fix/remove_container_debugee 2023-10-19 15:12:54 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#745
No description provided.