Fix Badger writecache race #765

dstepanov-yadro · 2023-10-30T14:12:19Z

dstepanov-yadro commented

2023-10-30 14:12:19 +00:00

Closes #728

dstepanov-yadro requested review from storage-core-committers 2023-10-30 14:32:05 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-10-30 14:32:06 +00:00

fyrchik approved these changes 2023-10-30 14:38:07 +00:00

pkg/local_object_storage/writecache/writecachebadger/cachebadger.go Outdated

													
				@ -85,6 +85,9 @@ func (c *cache) DumpInfo() writecache.Info {

				// Open opens and initializes database. Reads object counters from the ObjectCounters instance.

				func (c *cache) Open(_ context.Context, readOnly bool) error {

					c.modeMtx.Lock()

fyrchik commented

2023-10-30 14:38:04 +00:00

There we races in SetMode, is it fixed with this?

There we races in `SetMode`, is it fixed with this?

dstepanov-yadro commented

2023-10-30 15:39:02 +00:00

Poster

Hm, SetMode is already protected by mutex.

WARNING: DATA RACE
Write at 0x00c0001a2378 by goroutine 861:
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger.(*cache).openStore()
      /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger/storage.go:53 +0x145

Previous read at 0x00c0001a2378 by goroutine 1244:
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger.(*cache).runGCLoop.func1()
      /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger/gc.go:33 +0x2a8

I've missed fix for GC, so now it's ok.

Hm, `SetMode` is already protected by mutex. ``` WARNING: DATA RACE Write at 0x00c0001a2378 by goroutine 861: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger.(*cache).openStore() /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger/storage.go:53 +0x145 Previous read at 0x00c0001a2378 by goroutine 1244: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger.(*cache).runGCLoop.func1() /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/writecache/writecachebadger/gc.go:33 +0x2a8 ``` I've missed fix for GC, so now it's ok.