TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

morph: Cleanup InvocationScript before sign #776

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/clean-inv-script into support/v0.37 2023-12-11 16:46:46 +00:00
Conversation 1 Commits 1 Files changed 5 +30
acid-ant commented 2023-11-01 11:59:33 +00:00
Member
Copy link

Necessary to skip check on the neo-go side.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Necessary to skip check on the neo-go side. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
🚀 1
fyrchik reviewed 2023-11-01 12:16:49 +00:00
pkg/morph/client/notary.go Outdated
@ -418,6 +418,17 @@ func (c *Client) NotarySignAndInvokeTX(mainTx *transaction.Transaction) error {
return err
}
// This is necessary to suppress this check on neo-go side:
fyrchik commented 2023-11-01 12:16:49 +00:00
Owner
Copy link

Can we mention that this is a kludge purely for update to work?

Can we mention that this is a kludge purely for update to work?
acid-ant commented 2023-11-01 12:47:52 +00:00
Author
Member
Copy link

Updated.

Updated.
fyrchik marked this conversation as resolved
fyrchik added the
kludge
 label 2023-11-01 12:16:55 +00:00
JuliaKovshova approved these changes 2023-11-01 12:26:51 +00:00
acid-ant force-pushed bugfix/clean-inv-script from ac3076e5ca to 8860b2dfa7 2023-11-01 12:46:48 +00:00 Compare
acid-ant force-pushed bugfix/clean-inv-script from 8860b2dfa7 to 6d96605190 2023-11-01 12:47:47 +00:00 Compare
acid-ant force-pushed bugfix/clean-inv-script from 6d96605190 to a983b68294 2023-11-08 11:59:31 +00:00 Compare
acid-ant force-pushed bugfix/clean-inv-script from a983b68294 to 1415bb3433 2023-11-13 07:46:33 +00:00 Compare
acid-ant commented 2023-11-13 07:48:09 +00:00
Author
Member
Copy link

Added config "morph.keepinvscript" to disable/enable kludge.

Added config "morph.keepinvscript" to disable/enable kludge.
acid-ant force-pushed bugfix/clean-inv-script from 1415bb3433 to bb5b3a93dc 2023-12-05 09:07:48 +00:00 Compare
acid-ant force-pushed bugfix/clean-inv-script from bb5b3a93dc to 7d9fe03f28 2023-12-11 09:21:41 +00:00 Compare
acid-ant changed title from WIP: morph: Cleanup InvocationScript before sign to morph: Cleanup InvocationScript before sign 2023-12-11 09:22:33 +00:00
acid-ant requested review from storage-core-committers 2023-12-11 09:23:50 +00:00
acid-ant requested review from storage-core-developers 2023-12-11 09:23:51 +00:00
dstepanov-yadro approved these changes 2023-12-11 10:43:17 +00:00
fyrchik approved these changes 2023-12-11 12:46:27 +00:00
cmd/frostfs-node/config.go
@ -213,2 +214,4 @@
a.EngineCfg.rebuildWorkers = engineconfig.EngineRebuildWorkersCount(c)
// Kludge
client.KeepInvScript = morphconfig.KeepInvocationScript(c)
fyrchik commented 2023-12-11 12:46:25 +00:00
Owner
Copy link

Do we read this with SIGHUP? Could be a data race.

Do we read this with SIGHUP? Could be a data race.
acid-ant commented 2023-12-11 19:08:40 +00:00
Author
Member
Copy link

Yes, we read it at SIGHUP too, and yes it is possible for data race. But we use this variable when react on events which happens not so far. Also, when system upgraded, it works in both scenarios as I remember - when kludged enabled/disabled.

Yes, we read it at SIGHUP too, and yes it is possible for data race. But we use this variable when react on events which happens not so far. Also, when system upgraded, it works in both scenarios as I remember - when kludged enabled/disabled.
fyrchik approved these changes 2023-12-11 16:46:36 +00:00
fyrchik merged commit 7d9fe03f28 into support/v0.37 2023-12-11 16:46:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
JuliaKovshova
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#776
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/clean-inv-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?