adm: Add dump policy #783

achuprov · 2023-11-02T12:18:15Z

achuprov commented

2023-11-02 12:18:15 +00:00

Close #716

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #716 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

image.png

20 KiB

achuprov force-pushed dump-police from 0ef29c4fbe to ac463a4bd2

2023-11-02 12:19:15 +00:00

Compare

fyrchik requested review from storage-core-committers 2023-11-02 12:20:29 +00:00

fyrchik reviewed 2023-11-02 12:21:06 +00:00

cmd/frostfs-adm/internal/modules/morph/root.go Outdated

													
				@ -147,2 +147,4 @@

					}

					dumpPolicy = &cobra.Command{

						Use:   "dump-police",

fyrchik commented

2023-11-02 12:21:06 +00:00

s/police/policy/

achuprov commented

2023-11-02 12:36:02 +00:00

Poster

fixed × 3x

😆 1

fyrchik marked this conversation as resolved

fyrchik reviewed 2023-11-02 12:21:09 +00:00

cmd/frostfs-adm/internal/modules/morph/root.go Outdated

													
				@ -147,2 +147,4 @@

					}

					dumpPolicy = &cobra.Command{

						Use:   "dump-police",

fyrchik commented

2023-11-02 12:21:09 +00:00

s/police/policy/

fyrchik marked this conversation as resolved

fyrchik reviewed 2023-11-02 12:21:13 +00:00

cmd/frostfs-adm/internal/modules/morph/root.go Outdated

													
				@ -147,2 +147,4 @@

					}

					dumpPolicy = &cobra.Command{

						Use:   "dump-police",

fyrchik commented

2023-11-02 12:21:12 +00:00

s/police/policy/

fyrchik marked this conversation as resolved

fyrchik approved these changes 2023-11-02 12:21:24 +00:00

achuprov force-pushed dump-police from ac463a4bd2 to aafe6206b0

2023-11-02 12:34:43 +00:00

Compare

achuprov requested review from storage-core-committers 2023-11-02 12:36:17 +00:00

achuprov requested review from storage-core-developers 2023-11-02 12:36:19 +00:00

achuprov force-pushed dump-police from aafe6206b0 to 5f1d0d84dd

2023-11-02 12:39:17 +00:00

Compare

aarifullin reviewed 2023-11-02 12:54:23 +00:00

cmd/frostfs-adm/internal/modules/morph/policy.go Outdated

													
				@ -55,0 +59,4 @@

				func dumpPolicyCmd(cmd *cobra.Command, _ []string) error {

					c, err := getN3Client(viper.GetViper())

					if err != nil {

						return fmt.Errorf("can't create N3 client: %w", err)

aarifullin commented

2023-11-02 12:54:23 +00:00

I don't mind if you return the error here (and below). But I also see you pass cmd *cobra.Command to this method.

How about to consider using commonCmd.ExitOnErr(cmd, "your txt", err) . This allows to exit the program and you do not need to check if err != nil :)

I don't mind if you return the error here (and below). But I also see you pass `cmd *cobra.Command` to this method. How about to consider using `commonCmd.ExitOnErr(cmd, "your txt", err)` . This allows to exit the program and you do not need to check `if err != nil` :)

achuprov commented

2023-11-02 13:22:01 +00:00

Poster

fixed