TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 96 Pull requests 4 Projects Releases 1 Activity Actions

Drop neo-go's slices package usage #815

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/drop_slice_copy into master 2023-11-17 10:56:28 +00:00
Conversation 2 Commits 1 Files changed 9 +25 -20
dstepanov-yadro commented 2023-11-17 08:09:25 +00:00
Member
Copy link

Closes #96

Closes #96
fyrchik approved these changes 2023-11-17 08:43:48 +00:00
pkg/innerring/processors/frostfs/handlers.go Outdated
@ -14,2 +15,4 @@
func (np *Processor) handleDeposit(ev event.Event) {
deposit := ev.(frostfsEvent.Deposit)
depositIDBin := bytes.Clone(deposit.ID())
slices.Reverse[[]byte](depositIDBin)
fyrchik commented 2023-11-17 08:43:09 +00:00
Owner
Copy link

Hm, do we need type annotation here? It is similar to line 37 in the same file.

Hm, do we _need_ type annotation here? It is similar to line 37 in the same file.
dstepanov-yadro commented 2023-11-17 08:58:48 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
fyrchik commented 2023-11-17 08:45:10 +00:00
Owner
Copy link

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet
dstepanov-yadro force-pushed fix/drop_slice_copy from c1e26fc28e to d3143341da 2023-11-17 08:55:47 +00:00 Compare
dstepanov-yadro force-pushed fix/drop_slice_copy from d3143341da to 42d3ca0d1c 2023-11-17 08:58:42 +00:00 Compare
dstepanov-yadro commented 2023-11-17 10:13:38 +00:00
Author
Member
Copy link

https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet

Fixed

> https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet Fixed
dstepanov-yadro force-pushed fix/drop_slice_copy from 42d3ca0d1c to f8d8573cfc 2023-11-17 10:14:28 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-11-17 10:19:59 +00:00
fyrchik requested review from storage-core-developers 2023-11-17 10:20:02 +00:00
fyrchik approved these changes 2023-11-17 10:21:07 +00:00
dstepanov-yadro force-pushed fix/drop_slice_copy from f8d8573cfc to 76ff26039c 2023-11-17 10:24:20 +00:00 Compare
acid-ant approved these changes 2023-11-17 10:39:21 +00:00
dstepanov-yadro merged commit 76ff26039c into master 2023-11-17 10:56:28 +00:00
dstepanov-yadro deleted branch fix/drop_slice_copy 2023-11-17 10:56:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#815
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/drop_slice_copy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?