Drop neo-go's slices package usage #815

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/drop_slice_copy into master 2023-11-17 10:56:28 +00:00

Closes #96

Closes #96
fyrchik approved these changes 2023-11-17 08:43:48 +00:00
@ -14,2 +15,4 @@
func (np *Processor) handleDeposit(ev event.Event) {
deposit := ev.(frostfsEvent.Deposit)
depositIDBin := bytes.Clone(deposit.ID())
slices.Reverse[[]byte](depositIDBin)
Owner

Hm, do we need type annotation here? It is similar to line 37 in the same file.

Hm, do we _need_ type annotation here? It is similar to line 37 in the same file.
Author
Member

Fixed

Fixed
fyrchik marked this conversation as resolved
Owner
https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet
dstepanov-yadro force-pushed fix/drop_slice_copy from c1e26fc28e to d3143341da 2023-11-17 08:55:47 +00:00 Compare
dstepanov-yadro force-pushed fix/drop_slice_copy from d3143341da to 42d3ca0d1c 2023-11-17 08:58:42 +00:00 Compare
Author
Member
> https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/3042/jobs/1 -- we are not 1.21 yet Fixed
dstepanov-yadro force-pushed fix/drop_slice_copy from 42d3ca0d1c to f8d8573cfc 2023-11-17 10:14:28 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-11-17 10:19:59 +00:00
fyrchik requested review from storage-core-developers 2023-11-17 10:20:02 +00:00
fyrchik approved these changes 2023-11-17 10:21:07 +00:00
dstepanov-yadro force-pushed fix/drop_slice_copy from f8d8573cfc to 76ff26039c 2023-11-17 10:24:20 +00:00 Compare
acid-ant approved these changes 2023-11-17 10:39:21 +00:00
dstepanov-yadro merged commit 76ff26039c into master 2023-11-17 10:56:28 +00:00
dstepanov-yadro deleted branch fix/drop_slice_copy 2023-11-17 10:56:31 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#815
No description provided.