TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 105 Pull requests 3 Projects Releases 2 Activity Actions

writecache: Fix flush test #817

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/test_flush_flaky into master 2023-11-20 15:09:37 +00:00
Conversation 0 Commits 1 Files changed 8 +40 -36
dstepanov-yadro commented 2023-11-17 14:48:35 +00:00
Member
Copy link

There is nothing wrong in logs. So highly likely background flusher has been incremented error counter before Flush call.

Now it is allowed to disable background flusher for testing purposes.

Closes #667

There is nothing wrong in logs. So highly likely background flusher has been incremented error counter before `Flush` call. Now it is allowed to disable background flusher for testing purposes. Closes #667
dstepanov-yadro added 1 commit 2023-11-17 14:48:40 +00:00
[#667] writecache: Fix flush test
All checks were successful
DCO action / DCO (pull_request) Successful in 1m28s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m55s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m15s
Details
Build / Build Components (1.21) (pull_request) Successful in 4m40s
Details
Build / Build Components (1.20) (pull_request) Successful in 4m54s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 5m32s
Details
Tests and linters / Lint (pull_request) Successful in 5m59s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 6m59s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m57s
Details
8d18fa159e 
Allow to disable background flusher for testing purposes.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro reviewed 2023-11-17 14:51:27 +00:00
dstepanov-yadro reviewed 2023-11-17 14:51:29 +00:00
dstepanov-yadro reviewed 2023-11-17 14:51:32 +00:00
pkg/local_object_storage/writecache/writecachebbolt/storage.go
@ -96,3 +96,1 @@
func (c *cache) deleteFromDisk(ctx context.Context, keys []string) []string {
if len(keys) == 0 {
return keys
func (c *cache) deleteFromDisk(ctx context.Context, addr oid.Address) {
dstepanov-yadro commented 2023-11-17 14:51:32 +00:00
Author
Member
Copy link

This change doesn't relate to fix, but small refactoring.

This change doesn't relate to fix, but small refactoring.
👍 1
dstepanov-yadro requested review from storage-core-committers 2023-11-17 14:56:47 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-11-17 14:56:48 +00:00
aarifullin approved these changes 2023-11-20 09:24:55 +00:00
acid-ant approved these changes 2023-11-20 11:35:59 +00:00
dstepanov-yadro merged commit 8d18fa159e into master 2023-11-20 15:09:37 +00:00
dstepanov-yadro deleted branch fix/test_flush_flaky 2023-11-20 15:09:39 +00:00
fyrchik reviewed 2023-11-21 07:01:37 +00:00
pkg/local_object_storage/writecache/writecachebbolt/options.go
@ -157,1 +159,4 @@
}
// WithDisableBackgroundFlush disables background flush, for testing purposes only.
func WithDisableBackgroundFlush() Option {
fyrchik commented 2023-11-20 07:15:54 +00:00
Owner
Copy link

If it is for tests only, can we define it in _test.go file?

If it is for tests only, can we define it in `_test.go` file?
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#817
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/test_flush_flaky"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?