TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 103 Pull requests 4 Projects Releases 2 Activity Actions

Store tree service sync height in the metabase #82

Merged
fyrchik merged 2 commits from fyrchik/tree-service-store-sync-height into master 2023-03-13 11:25:45 +00:00
Conversation 0 Commits 2 Files changed 10 +189 -28
fyrchik commented 2023-03-01 11:30:20 +00:00 (Migrated from github.com)
Copy link

While it changes storage scheme, we can update safely -- after initial sync new height will be saved.

While it changes storage scheme, we can update safely -- after initial sync new height will be saved.
fyrchik requested review from storage-core-committers 2023-03-06 19:13:49 +00:00
fyrchik requested review from storage-core-developers 2023-03-06 19:13:49 +00:00
fyrchik started working 2023-03-06 19:18:36 +00:00
carpawell reviewed 2023-03-09 16:52:13 +00:00
CHANGELOG.md
@ -13,6 +13,7 @@ Changelog for FrostFS Node
- Reload config for pprof and metrics on SIGHUP in `neofs-node` (#1868)
- Multiple configs support (#44)
- Parameters `nns-name` and `nns-zone` for command `frostfs-cli container create` (#37)
- Tree service now saves the last synchronization height which persists across restarts (#82)
carpawell commented 2023-03-09 16:44:17 +00:00
Contributor
Copy link

"82"? we will have conflicts some day then

"82"? we will have conflicts some day then
fyrchik commented 2023-03-09 20:21:03 +00:00
Owner
Copy link

What do you mean? This PR is #82.

What do you mean? This PR is #82.
carpawell commented 2023-03-10 15:01:47 +00:00
Contributor
Copy link

what we gonna do when #1868 PR is open in that repo?

what we gonna do when `#1868` PR is open in that repo?
fyrchik commented 2023-03-10 15:04:48 +00:00
Owner
Copy link

We will discuss, but it is unrelated to this PR.

We will discuss, but it is unrelated to this PR.
carpawell commented 2023-03-10 15:09:34 +00:00
Contributor
Copy link

it is unrelated to this PR

sure but i would discuss it as early as possible since we are already filling CHANGELOG with conflicting lines (adjacent rows belong to the different lists, what is that file for then?)

> it is unrelated to this PR sure but i would discuss it as early as possible since we are already filling CHANGELOG with conflicting lines (adjacent rows belong to the different lists, what is that file for then?)
pkg/local_object_storage/engine/tree.go
@ -216,0 +234,4 @@
var err error
var height uint64
for _, sh := range e.sortShardsByWeight(cid) {
height, err = sh.TreeLastSyncHeight(cid, treeID)
carpawell commented 2023-03-09 16:50:19 +00:00
Contributor
Copy link

why not getTreeShard?

why not `getTreeShard`?
fyrchik commented 2023-03-09 20:25:21 +00:00
Owner
Copy link

Mostly because this is a general rule here.
The reason is that getTreeShard performs TreeExists just to find the shard and is really needed only for modifying operations.
TreeLastSyncHeight is cheap, so we can safely use it here without calling TreeExists for each shard in getTreeShard.

Mostly because this is a general rule here. The reason is that `getTreeShard` performs `TreeExists` just to find the shard and is really needed only for modifying operations. `TreeLastSyncHeight` is cheap, so we can safely use it here without calling `TreeExists` for each shard in `getTreeShard`.
carpawell marked this conversation as resolved
acid-ant approved these changes 2023-03-10 10:42:57 +00:00
carpawell approved these changes 2023-03-10 15:09:40 +00:00
fyrchik merged commit 6cd806f998 into master 2023-03-13 11:25:45 +00:00
fyrchik stopped working 2023-03-13 11:25:45 +00:00
6 days 16 hours
fyrchik deleted branch fyrchik/tree-service-store-sync-height 2023-03-13 11:25:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
carpawell
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#82
No description provided.
Delete branch "fyrchik/tree-service-store-sync-height"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?