TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 92 Pull requests 4 Projects Releases 1 Activity Actions

cli: Support passing chain ID in add-rule command #824

Closed
aarifullin wants to merge 1 commit from feature/chain_id_add_rule into master
pull from: feature/chain_id_add_rule
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 1 +4
aarifullin commented 2023-11-21 14:04:26 +00:00
Member
Copy link

Assigning chain ID in add-rule can be useful to write test scenarios

Assigning chain ID in `add-rule` can be useful to write test scenarios
aarifullin added the
frostfs-cli
 label 2023-11-21 14:04:26 +00:00
aarifullin force-pushed feature/chain_id_add_rule from eb5ceedb7f to e249c95844 2023-11-21 14:05:05 +00:00 Compare
aarifullin requested review from storage-core-committers 2023-11-21 14:05:10 +00:00
aarifullin requested review from storage-core-developers 2023-11-21 14:05:20 +00:00
acid-ant approved these changes 2023-11-22 08:13:03 +00:00
dstepanov-yadro approved these changes 2023-11-24 12:28:36 +00:00
fyrchik requested changes 2023-11-27 07:02:37 +00:00
fyrchik left a comment
Owner
Copy link

Please, use cli: prefix, not frostfs-cli:

Please, use `cli:` prefix, not `frostfs-cli:`
aarifullin changed title from frostfs-cli: Support passing chain ID in add-rule command to cli: Support passing chain ID in add-rule command 2023-11-29 14:08:49 +00:00
aarifullin commented 2023-11-29 14:16:40 +00:00
Author
Member
Copy link

Sorry, this PR moved to #832

Sorry, this PR moved to [#832](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/832)
aarifullin closed this pull request 2023-11-29 14:16:41 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 4m43s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 5m30s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 6m28s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 6m32s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m31s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 6m58s
Required
Details
Tests and linters / Lint (pull_request) Successful in 7m27s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 7m49s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m44s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#824
No description provided.
Delete branch "feature/chain_id_add_rule"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?