TrueCloudLab/frostfs-node

engine: Speedup tests #827

Merged

fyrchik merged 3 commits from achuprov/frostfs-node:speed_up_tests into master

2023-11-30 13:19:45 +00:00

achuprov commented

2023-11-27 09:25:21 +00:00

Member

Before:

time make test 
...
real    0m22,378s
user    1m8,662s
sys     0m8,029s

After:

time make test 
...
real    0m15,648s
user    1m5,805s
sys     0m7,551s

#651
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Before: ``` time make test ... real 0m22,378s user 1m8,662s sys 0m8,029s ``` After: ``` time make test ... real 0m15,648s user 1m5,805s sys 0m7,551s ``` #651 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

achuprov force-pushed speed_up_tests from 3ca211ecf2 to c516c7c5f4

2023-11-27 09:27:25 +00:00

Compare

achuprov requested review from storage-core-committers 2023-11-27 09:45:22 +00:00

achuprov requested review from storage-core-developers 2023-11-27 09:45:22 +00:00

fyrchik approved these changes 2023-11-27 09:53:03 +00:00

pkg/local_object_storage/shard/delete_test.go Outdated

					
				@ -24,3 +17,1 @@

						t.Parallel()

						testShardDelete(t, true)

					})

					testShard(t, false, 1<<5) // Small object, without write cache

fyrchik commented

2023-11-27 09:52:57 +00:00

Owner

What is the point of this (TestShard_Delete()) refactoring?
It seems, same tests are executed in the same order.

What is the point of this (`TestShard_Delete()`) refactoring? It seems, same tests are executed in the same order.

achuprov commented

2023-11-27 10:59:42 +00:00

Author

Member

fixed

fixed

fyrchik commented

2023-11-27 17:07:33 +00:00

Owner

The diff still seems too big if no changes besides Flush were done.

The diff still seems too big if no changes besides `Flush` were done.

achuprov commented

2023-11-28 14:59:14 +00:00

Author

Member

The small object and big object tests had the same code, so they were combined and put into a auxiliary function.

The `small object` and `big object` tests had the same code, so they were combined and put into a auxiliary function.

fyrchik commented

2023-11-29 06:25:00 +00:00

Owner

It seems like an unrelated change, can we do this refactoring in a separate commit?

It seems like an unrelated change, can we do this refactoring in a separate commit?

achuprov commented

2023-11-29 08:06:52 +00:00

Author

Member

fixed

fixed

achuprov force-pushed speed_up_tests from 1b46f7fd86 to 8263727755

2023-11-27 10:58:29 +00:00

Compare

achuprov force-pushed speed_up_tests from 8263727755 to b281a2f7e2

2023-11-27 11:01:03 +00:00

Compare

dstepanov-yadro approved these changes 2023-11-29 07:01:00 +00:00

achuprov force-pushed speed_up_tests from b281a2f7e2 to 54e1e29de9

2023-11-29 07:52:55 +00:00

Compare

achuprov force-pushed speed_up_tests from 54e1e29de9 to d6c7424eaa

2023-11-29 07:53:45 +00:00

Compare

aarifullin approved these changes 2023-11-29 08:34:42 +00:00

acid-ant approved these changes 2023-11-29 14:48:14 +00:00

fyrchik approved these changes 2023-11-30 13:19:34 +00:00

fyrchik merged commit b2c63e57ba into master

2023-11-30 13:19:45 +00:00

achuprov referenced this pull request

2023-12-08 08:56:55 +00:00

Speedup engine and pilorama tests #651

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

5 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#827

No description provided.