Fix tree service sync #829

Merged

fyrchik merged 3 commits from dstepanov-yadro/frostfs-node:fix/tree_service_from into master 2023-11-30 12:45:04 +00:00

Conversation 0 Commits 3 Files changed 2 +71 -58

dstepanov-yadro commented 2023-11-28 07:53:23 +00:00

Member

Copy link

Closes #741

• Do not update last sync height if some node is not available

• Some refactorings

Closes #741 * Do not update last sync height if some node is not available * Some refactorings

dstepanov-yadro added 2 commits 2023-11-28 07:53:26 +00:00

[#741] treesvc: Remove unused height variables ... b8a3f17759

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

[#741] treesvc: Do not update sync height if some node is unavailable ... 1c735efedd

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

dstepanov-yadro added 1 commit 2023-11-28 14:04:54 +00:00

[#741] treesvc: Refactor tree sync ... b20298007e

Fix linter issues.
Add error logging.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

dstepanov-yadro requested review from storage-core-committers 2023-11-28 14:15:46 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-11-28 14:15:46 +00:00

dstepanov-yadro changed title from WIP: Fix tree service sync to Fix tree service sync 2023-11-28 14:15:54 +00:00

aarifullin approved these changes 2023-11-28 14:23:38 +00:00

aarifullin left a comment

Member

Copy link

Brilliant fix!

Brilliant fix!

acid-ant approved these changes 2023-11-29 14:42:38 +00:00

fyrchik approved these changes 2023-11-30 12:44:50 +00:00

fyrchik merged commit 26e4f7005c into master 2023-11-30 12:45:04 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

aarifullin

acid-ant

fyrchik

Labels

Clear labels   

P0

Highest

  

P1

High

  

P2

Medium

  

P3

Low

  

badger

Badger DB related issues

  

frostfs-adm

  

frostfs-cli

  

frostfs-ir

  

frostfs-lens

  

frostfs-node

  

good first issue

Good for newcomers

  

triage

  

Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  

blocked

The issue or PR is blocked by something

  

bug

Something is not working

  

config

Configuration format update or breaking change

  

discussion

Talking about something in order to reach a decision or to exchange ideas

  

documentation

Documentation related

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

go

Language features adoption

  

help wanted

Extra attention is needed

  

internal

  

invalid

Something is wrong

  

kludge

This is a kludge and we know it

  

observability

Related to metrics, tracing and logs

  

perfomance

Perfomance related

  

question

More information is needed

  

refactoring

Refactoring

  

wontfix

This won't be fixed

No labels

P0

P1

P2

P3

badger

frostfs-adm

frostfs-cli

frostfs-ir

frostfs-lens

frostfs-node

good first issue

triage

Infrastructure

blocked

bug

config

discussion

documentation

duplicate

enhancement

go

help wanted

internal

invalid

kludge

observability

perfomance

question

refactoring

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#829

No description provided.