TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 6 Projects Releases 2 Activity Actions

node: Refactor TTL cache #831

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:ttl_cache into master 2023-11-30 12:54:53 +00:00
Conversation 0 Commits 1 Files changed 2 +65 -20
achuprov commented 2023-11-29 13:23:50 +00:00
Member
Copy link

Migrate from internal to external TTL implementation

Closes: #639

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Migrate from internal to external TTL implementation Closes: #639 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2023-11-29 13:28:58 +00:00
aarifullin reviewed 2023-11-29 14:31:02 +00:00
cmd/frostfs-node/cache_test.go Outdated
@ -0,0 +27,4 @@
cache.set(key, ti, nil)
time.Sleep(2 * ttlDuration)
val, err := cache.get(key)
assert.Nil(t, err)
aarifullin commented 2023-11-29 14:31:02 +00:00
Member
Copy link

-> assert.NoError? :)

-> `assert.NoError`? :)
dstepanov-yadro commented 2023-11-29 14:55:03 +00:00
Member
Copy link

require.NoError better

`require.NoError` better
achuprov commented 2023-11-30 08:46:21 +00:00
Author
Member
Copy link

fixed

fixed
aarifullin reviewed 2023-11-29 14:32:33 +00:00
cmd/frostfs-node/cache_test.go Outdated
@ -0,0 +28,4 @@
time.Sleep(2 * ttlDuration)
val, err := cache.get(key)
assert.Nil(t, err)
assert.NotEqual(t, val, ti)
aarifullin commented 2023-11-29 14:32:33 +00:00
Member
Copy link

Am I right that values are not equeal because the entry is expired after time.Sleep(2 * ttlDuration)?

Am I right that values are not equeal because the entry is expired after `time.Sleep(2 * ttlDuration)`?
achuprov commented 2023-11-30 08:41:24 +00:00
Author
Member
Copy link

Yes, you are correct. The values are not equal because the entry has expired after the time.Sleep(2 * ttl Duration) interval

Yes, you are correct. The values are not equal because the entry has expired after the `time.Sleep(2 * ttl Duration)` interval
fyrchik approved these changes 2023-11-29 15:26:21 +00:00
cmd/frostfs-node/cache.go Outdated
@ -33,3 +29,1 @@
netRdr netValueReader[K, V]
cache *expirable.LRU[K, *valueWithTime[V]]
fyrchik commented 2023-11-29 15:26:19 +00:00
Owner
Copy link

If it is expireable, why do we use *valueWithTime[V] instead of *V?

If it is expireable, why do we use `*valueWithTime[V]` instead of `*V`?
fyrchik commented 2023-11-29 15:27:03 +00:00
Owner
Copy link

Approved by accident, please disregard.

Approved by accident, please disregard.
achuprov commented 2023-11-30 08:41:39 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
achuprov force-pushed ttl_cache from ac06af2940 to b9441b3479 2023-11-30 08:37:05 +00:00 Compare
achuprov force-pushed ttl_cache from b9441b3479 to 30b237e176 2023-11-30 08:46:09 +00:00 Compare
dstepanov-yadro approved these changes 2023-11-30 11:53:49 +00:00
fyrchik approved these changes 2023-11-30 12:53:37 +00:00
fyrchik merged commit 7f6852bbd2 into master 2023-11-30 12:54:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#831
No description provided.
Delete branch "achuprov/frostfs-node:ttl_cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?