TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Customer object counter #843

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/customer_objects_metric into master 2024-09-04 19:51:05 +00:00
Conversation 2 Commits 1 Files changed 1 +76 -65
dstepanov-yadro commented 2023-12-05 14:03:15 +00:00
Member
Copy link

Customer object - regular object without splitID (simple object) or last part of complex object (with splitID and parentID, but without children - linking object has children).

Affected metrics - frostfs_node_engine_objects_total{type="customer"} & frostfs_node_engine_container_objects_total{type="customer"}

Closes #838

Customer object - regular object without splitID (simple object) or last part of complex object (with splitID and parentID, but without children - linking object has children). Affected metrics - `frostfs_node_engine_objects_total{type="customer"}` & `frostfs_node_engine_container_objects_total{type="customer"}` Closes #838
dstepanov-yadro force-pushed feat/customer_objects_metric from e4384659f0 to 762df10e49 2023-12-05 14:04:08 +00:00 Compare
dstepanov-yadro force-pushed feat/customer_objects_metric from 762df10e49 to dc90b8e310 2023-12-06 09:10:03 +00:00 Compare
dstepanov-yadro changed title from WIP: Customer object counter to Customer object counter 2023-12-06 09:12:56 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-12-06 09:13:05 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-12-06 09:13:10 +00:00
fyrchik commented 2023-12-06 09:14:11 +00:00
Owner
Copy link

It it true that count(customer) <= count(logic) <= count(physical)?

It it true that `count(customer) <= count(logic) <= count(physical)`?
fyrchik approved these changes 2023-12-06 09:19:41 +00:00
pkg/local_object_storage/metabase/counter.go Outdated
@ -20,1 +20,3 @@
objectLogicCounterKey = []byte("logic_counter")
objectPhyCounterKey = []byte("phy_counter")
objectLogicCounterKey = []byte("logic_counter")
objectCustomerCounterKey = []byte("customer_counter")
fyrchik commented 2023-12-06 09:15:12 +00:00
Owner
Copy link

Maybe user_counter or root_counter?

Maybe `user_counter` or `root_counter`?
dstepanov-yadro commented 2023-12-06 10:33:52 +00:00
Author
Member
Copy link

Changed to user

Changed to user
pkg/local_object_storage/shard/put.go Outdated
@ -91,3 +91,3 @@
}
s.incObjectCounter(putPrm.Address.Container())
s.incObjectCounter(putPrm.Address.Container(), meta.IsCustomerObject(prm.obj))
fyrchik commented 2023-12-06 09:19:15 +00:00
Owner
Copy link

IsCustomerObject sounds cryptic, wouldn't be obvioius if I was new to the codebase.

`IsCustomerObject` sounds cryptic, wouldn't be obvioius if I was new to the codebase.
dstepanov-yadro commented 2023-12-06 10:34:01 +00:00
Author
Member
Copy link

Changed to user

Changed to user
dstepanov-yadro force-pushed feat/customer_objects_metric from dc90b8e310 to 5662a4dcc6 2023-12-06 10:02:58 +00:00 Compare
dstepanov-yadro commented 2023-12-06 10:03:17 +00:00
Author
Member
Copy link

It it true that count(customer) <= count(logic) <= count(physical)?

yes

> It it true that `count(customer) <= count(logic) <= count(physical)`? yes
dstepanov-yadro force-pushed feat/customer_objects_metric from 5662a4dcc6 to 045fa423ee 2023-12-06 10:33:34 +00:00 Compare
fyrchik approved these changes 2023-12-06 10:51:42 +00:00
acid-ant approved these changes 2023-12-06 11:11:26 +00:00
dstepanov-yadro force-pushed feat/customer_objects_metric from 045fa423ee to a478050639 2023-12-06 12:44:46 +00:00 Compare
fyrchik approved these changes 2023-12-06 13:29:11 +00:00
fyrchik merged commit a478050639 into master 2023-12-06 13:29:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#843
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/customer_objects_metric"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?