TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

storage node: Drain internal error's channel #878

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/shutdown_panic into master 2023-12-19 16:38:06 +00:00
Conversation 0 Commits 1 Files changed 2 +14 -1
dstepanov-yadro commented 2023-12-18 15:01:28 +00:00
Member
Copy link

Scenario:

  1. Some morph connection gets error and passes it to internalErr channel
  2. Storage node starts to shutdow and closes internalErr channel
  3. Other morph connection gets error and tries to pass it to internalErr channel => panic:
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: panic: send on closed channel
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: goroutine 4136 [running]:
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).listenLoop(0xc000176780, {0x162fe20, 0xc0002a5c70}, 0xc0002bc240, 0xc001054c60)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:238 +0x433
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).listen(0xc000176780, {0x162fe20, 0xc0002a5c70}, 0x43?)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:169 +0xb6
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).ListenWithError.func1()
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:152 +0x45
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync.(*Once).doSlow(0x193af2b?, 0x43?)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         sync/once.go:74 +0xc2
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync.(*Once).Do(...)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         sync/once.go:65
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).ListenWithError(0xc00440c270?, {0x162fe20?, 0xc0002a5c70?}, 0x0?)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:151 +0x67
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.listenMorphNotifications.func1.1({0x162fe20?, 0xc0002a5c70?}, 0xc000d37f10?)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/morph.go:213 +0x39
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.runAndLog({0x162fe20, 0xc0002a5c70}, 0xc000297800, {0x13c0fcc, 0x12}, 0x0, 0xc000276f68)
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/main.go:116 +0xc4
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.listenMorphNotifications.func1({0x162fe20?, 0xc0002a5c70?})
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/morph.go:212 +0x68
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.startWorker.func1({{0x0?, 0xc004c94400?}, 0xc00272ca60?})
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/worker.go:28 +0x37
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: created by main.startWorker
дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]:         git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/worker.go:27 +0x138
дек 12 02:37:31 blackmetal-node16 systemd[1]: frostfs-storage.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
дек 12 02:37:31 blackmetal-node16 systemd[1]: frostfs-storage.service: Failed with result 'exit-code'.
Scenario: 1. Some morph connection gets error and passes it to `internalErr` channel 2. Storage node starts to shutdow and closes `internalErr` channel 3. Other morph connection gets error and tries to pass it to `internalErr` channel => panic: ``` дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: panic: send on closed channel дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: goroutine 4136 [running]: дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).listenLoop(0xc000176780, {0x162fe20, 0xc0002a5c70}, 0xc0002bc240, 0xc001054c60) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:238 +0x433 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).listen(0xc000176780, {0x162fe20, 0xc0002a5c70}, 0x43?) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:169 +0xb6 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).ListenWithError.func1() дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:152 +0x45 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync.(*Once).doSlow(0x193af2b?, 0x43?) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync/once.go:74 +0xc2 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync.(*Once).Do(...) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: sync/once.go:65 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event.(*listener).ListenWithError(0xc00440c270?, {0x162fe20?, 0xc0002a5c70?}, 0x0?) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/morph/event/listener.go:151 +0x67 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.listenMorphNotifications.func1.1({0x162fe20?, 0xc0002a5c70?}, 0xc000d37f10?) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/morph.go:213 +0x39 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.runAndLog({0x162fe20, 0xc0002a5c70}, 0xc000297800, {0x13c0fcc, 0x12}, 0x0, 0xc000276f68) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/main.go:116 +0xc4 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.listenMorphNotifications.func1({0x162fe20?, 0xc0002a5c70?}) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/morph.go:212 +0x68 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: main.startWorker.func1({{0x0?, 0xc004c94400?}, 0xc00272ca60?}) дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/worker.go:28 +0x37 дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: created by main.startWorker дек 12 02:37:31 blackmetal-node16 frostfs-node[7839]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/worker.go:27 +0x138 дек 12 02:37:31 blackmetal-node16 systemd[1]: frostfs-storage.service: Main process exited, code=exited, status=2/INVALIDARGUMENT дек 12 02:37:31 blackmetal-node16 systemd[1]: frostfs-storage.service: Failed with result 'exit-code'. ```
dstepanov-yadro requested review from storage-core-committers 2023-12-18 15:23:06 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-12-18 15:23:07 +00:00
dstepanov-yadro force-pushed fix/shutdown_panic from d03042fcd4 to 3c16114465 2023-12-18 15:47:50 +00:00 Compare
aarifullin approved these changes 2023-12-18 16:16:30 +00:00
dstepanov-yadro force-pushed fix/shutdown_panic from 3c16114465 to 484836b9f9 2023-12-19 05:27:30 +00:00 Compare
acid-ant approved these changes 2023-12-19 06:34:56 +00:00
fyrchik merged commit d69d318cb0 into master 2023-12-19 16:38:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#878
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/shutdown_panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?