Add APE checks for container operations #881

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/containers_ape into master 2023-12-27 13:29:01 +00:00

Check policy engine for containers operations

Check policy engine for containers operations
dstepanov-yadro force-pushed feat/containers_ape from b8cccdb23d to 6db1b73269 2023-12-20 10:58:25 +00:00 Compare
dstepanov-yadro force-pushed feat/containers_ape from 6db1b73269 to 4e229ec7a8 2023-12-20 11:00:01 +00:00 Compare
dstepanov-yadro force-pushed feat/containers_ape from 4e229ec7a8 to 9e0d9f3654 2023-12-20 15:11:40 +00:00 Compare
dstepanov-yadro force-pushed feat/containers_ape from 9e0d9f3654 to 6acc11b5a2 2023-12-25 08:33:56 +00:00 Compare
dstepanov-yadro changed title from WIP: Add APE checks for container operations to Add APE checks for container operations 2023-12-25 08:34:18 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-12-25 08:34:26 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-12-25 08:34:27 +00:00
fyrchik approved these changes 2023-12-25 08:45:58 +00:00
@ -0,0 +41,4 @@
InnerRingKeys() ([][]byte, error)
}
type containers interface {
Owner

Why is it private? Can we use container.Source?

Why is it private? Can we use `container.Source`?
Author
Member

Because this interface for container's APE only. container.Source has other methods, that don't required for container's APE.

Because this interface for container's APE only. `container.Source` has other methods, that don't required for container's APE.
Owner

We have it as a parameter to a public New* function, I thought there was a linter for that.

We have it as a parameter to a public `New*` function, I thought there was a linter for that.
Author
Member

There is nothing wrong with non exported interfaces as exported method args: client passes implementation.

There is nothing wrong with non exported interfaces as exported method args: client passes implementation.
fyrchik marked this conversation as resolved
@ -0,0 +480,4 @@
if nm, found := s.netmaps[epoch]; found {
return nm, nil
}
return nil, fmt.Errorf("netmap not found")
Owner

errors.New?

`errors.New`?
Author
Member

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/containers_ape from 6acc11b5a2 to 9c3487c91e 2023-12-25 09:30:51 +00:00 Compare
dstepanov-yadro force-pushed feat/containers_ape from 9c3487c91e to 1c278e25c9 2023-12-27 05:50:42 +00:00 Compare
fyrchik approved these changes 2023-12-27 06:56:48 +00:00
@ -0,0 +474,4 @@
func (s *netmapStub) GetNetMap(diff uint64) (*netmap.NetMap, error) {
if diff >= s.currentEpoch {
return nil, fmt.Errorf("invalid diff")
Owner

errors.New?

`errors.New`?
Author
Member

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/containers_ape from 1c278e25c9 to 764f70634d 2023-12-27 08:05:49 +00:00 Compare
elebedeva approved these changes 2023-12-27 11:33:23 +00:00
aarifullin approved these changes 2023-12-27 13:13:25 +00:00
dstepanov-yadro merged commit 764f70634d into master 2023-12-27 13:29:01 +00:00
dstepanov-yadro deleted branch feat/containers_ape 2023-12-27 13:29:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#881
No description provided.