Add APE checks for container operations #881
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#881
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/containers_ape"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Check policy engine for containers operations
b8cccdb23d
to6db1b73269
6db1b73269
to4e229ec7a8
4e229ec7a8
to9e0d9f3654
9e0d9f3654
to6acc11b5a2
WIP: Add APE checks for container operationsto Add APE checks for container operations@ -0,0 +41,4 @@
InnerRingKeys() ([][]byte, error)
}
type containers interface {
Why is it private? Can we use
container.Source
?Because this interface for container's APE only.
container.Source
has other methods, that don't required for container's APE.We have it as a parameter to a public
New*
function, I thought there was a linter for that.There is nothing wrong with non exported interfaces as exported method args: client passes implementation.
@ -0,0 +480,4 @@
if nm, found := s.netmaps[epoch]; found {
return nm, nil
}
return nil, fmt.Errorf("netmap not found")
errors.New
?fixed
6acc11b5a2
to9c3487c91e
9c3487c91e
to1c278e25c9
@ -0,0 +474,4 @@
func (s *netmapStub) GetNetMap(diff uint64) (*netmap.NetMap, error) {
if diff >= s.currentEpoch {
return nil, fmt.Errorf("invalid diff")
errors.New
?fixed
1c278e25c9
to764f70634d