TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 5 Projects Releases 2 Activity Actions

adm: Suport proxy accounts #883

Merged
fyrchik merged 3 commits from alexvanin/frostfs-node:feature/proxy-accounts into master 2024-09-04 19:51:05 +00:00
Conversation 1 Commits 3 Files changed 11 +121 -15
alexvanin commented 2023-12-21 09:30:11 +00:00
Owner
Copy link
  • Deploy FrostFS ID and Policy contracts with Proxy contract admin by default
  • Add morph add-proxy-account and morph remove-proxy-account commands to manage list in proxy contract

Related to #880 so maybe it's worth to wait this PR first.
If this PR conflicts with frostfs-adm expectations, feel free to decline.

- Deploy FrostFS ID and Policy contracts with Proxy contract admin by default - Add `morph add-proxy-account` and `morph remove-proxy-account` commands to manage list in proxy contract Related to https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/880 so maybe it's worth to wait this PR first. If this PR conflicts with frostfs-adm expectations, feel free to decline.
👍 1 🚀 1
alexvanin force-pushed feature/proxy-accounts from 5d14df1fef to c00953b27a 2023-12-21 09:31:12 +00:00 Compare
alexvanin requested review from storage-core-committers 2023-12-21 10:04:38 +00:00
alexvanin requested review from storage-core-developers 2023-12-21 10:04:39 +00:00
dkirillov reviewed 2023-12-21 10:15:49 +00:00
cmd/frostfs-adm/internal/modules/morph/account.go Outdated
@ -0,0 +46,4 @@
return fmt.Errorf("can't get NNS contract info: %w", err)
}
proxyHash, err := nnsResolveHash(wCtx.ReadOnlyInvoker, cs.Hash, proxyContract+".frostfs")
dkirillov commented 2023-12-21 10:15:49 +00:00
Member
Copy link

We have a lot of code +".frsotfs" across the morph package. Can we define one constant for that (or function that forms full contact name)?

We have a lot of code `+".frsotfs"` across the `morph` package. Can we define one constant for that (or function that forms full contact name)?
👍 1
alexvanin commented 2023-12-21 11:00:08 +00:00
Author
Owner
Copy link

Added contractDomain in 44e60deba3

Added `contractDomain` in https://git.frostfs.info/TrueCloudLab/frostfs-node/commit/44e60deba3ef8971bee71aa8d00606e9bda7c06b
dkirillov approved these changes 2023-12-21 10:16:07 +00:00
dkirillov left a comment
Member
Copy link

LGTM

LGTM
fyrchik commented 2023-12-21 10:16:59 +00:00
Owner
Copy link

Maybe proxy-add-account and proxy-remove-account to group them in help and make similar to other things (netmap-*)

Maybe `proxy-add-account` and `proxy-remove-account` to group them in help and make similar to other things (netmap-*)
👍 1
fyrchik approved these changes 2023-12-21 10:17:43 +00:00
alexvanin force-pushed feature/proxy-accounts from c00953b27a to 44e60deba3 2023-12-21 10:59:56 +00:00 Compare
dkirillov approved these changes 2023-12-21 11:09:58 +00:00
acid-ant approved these changes 2023-12-21 11:24:19 +00:00
fyrchik approved these changes 2023-12-21 11:55:38 +00:00
cmd/frostfs-adm/internal/modules/morph/initialize_deploy.go Outdated
@ -91,6 +91,10 @@ const (
deployMethodName = "deploy"
)
func contractDomain(contract string) string {
fyrchik commented 2023-12-21 11:55:35 +00:00
Owner
Copy link

I am not too strong in naming, but maybe domainOf?

I am not too strong in naming, but maybe `domainOf`?
alexvanin commented 2023-12-21 12:04:19 +00:00
Author
Owner
Copy link

Sure, looks even better.

Sure, looks even better.
fyrchik marked this conversation as resolved
alexvanin force-pushed feature/proxy-accounts from 44e60deba3 to b1eab1de54 2023-12-21 12:04:14 +00:00 Compare
fyrchik approved these changes 2023-12-21 12:24:15 +00:00
fyrchik merged commit b1eab1de54 into master 2023-12-21 12:25:11 +00:00
fyrchik referenced this pull request from a commit 2023-12-21 12:25:14 +00:00
[#883] adm: Support proxy accounts
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#883
No description provided.
Delete branch "alexvanin/frostfs-node:feature/proxy-accounts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?