TrueCloudLab/frostfs-node

adm: Fix method `nnsResolveKey` #89

Merged

fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/adm-contract-upd into master

2023-03-09 14:46:01 +00:00

acid-ant commented

2023-03-07 11:55:35 +00:00

Member

Close #88

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #88 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant requested review from fyrchik 2023-03-07 11:55:53 +00:00

acid-ant requested review from carpawell 2023-03-07 11:55:53 +00:00

acid-ant requested review from dstepanov-yadro 2023-03-07 11:55:53 +00:00

acid-ant requested review from ale64bit 2023-03-07 11:55:53 +00:00

fyrchik reviewed 2023-03-07 13:22:47 +00:00

cmd/frostfs-adm/internal/modules/morph/initialize_nns.go Outdated

					
				@ -226,2 +229,2 @@

				func nnsResolve(inv *invoker.Invoker, nnsHash util.Uint160, domain string) (stackitem.Item, error) {

					return unwrap.Item(inv.Call(nnsHash, "resolve", domain, int64(nns.TXT)))

				func nnsResolve(inv *invoker.Invoker, nnsHash util.Uint160, domain string) ([]stackitem.Item, error) {

					return unwrap.Array(inv.Call(nnsHash, "resolve", domain, int64(nns.TXT)))

fyrchik commented

2023-03-07 13:22:47 +00:00

Owner

What happens if we have zero records? Is it Null or an empty array?

What happens if we have zero records? Is it Null or an empty array?

acid-ant force-pushed bugfix/adm-contract-upd from 63398c3158 to e4a8c4aad2

2023-03-09 12:33:31 +00:00

Compare

acid-ant force-pushed bugfix/adm-contract-upd from e4a8c4aad2 to 469c1ea477

2023-03-09 12:34:47 +00:00

Compare

acid-ant force-pushed bugfix/adm-contract-upd from 469c1ea477 to 7486c02bbc

2023-03-09 12:41:47 +00:00

Compare

acid-ant changed title from ~~adm: Fix method nnsResolve~~ to adm: Fix method nnsResolveKey

2023-03-09 12:41:53 +00:00

dstepanov-yadro approved these changes 2023-03-09 13:24:25 +00:00

fyrchik approved these changes 2023-03-09 14:45:56 +00:00

fyrchik merged commit 7486c02bbc into master

2023-03-09 14:46:01 +00:00

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#89

No description provided.