TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 94 Pull requests 3 Projects Releases 1 Activity Actions

Fix invalid session token type for container creation #900

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/create_container_session_context into master 2024-01-11 07:20:32 +00:00
Conversation 1 Commits 1 Files changed 2 +11 -9
dstepanov-yadro commented 2024-01-10 15:39:32 +00:00
Member
Copy link

Relates #899

Session context from object was used.

Relates #899 Session context from object was used.
dstepanov-yadro added 1 commit 2024-01-10 15:39:34 +00:00
[#899] containerSvc: Fix invalid session token type
Some checks failed
DCO action / DCO (pull_request) Successful in 1m23s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m29s
Details
Tests and linters / Tests (1.21) (pull_request) Failing after 3m58s
Details
Build / Build Components (1.21) (pull_request) Successful in 3m46s
Details
Build / Build Components (1.20) (pull_request) Successful in 3m52s
Details
Tests and linters / Lint (pull_request) Successful in 4m48s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m5s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m4s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m36s
Details
5c0a736a25 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro reviewed 2024-01-10 15:41:13 +00:00
pkg/services/container/ape.go
@ -424,2 +426,2 @@
func (ac *apeChecker) getActorAndPKFromSessionToken(st *sessionSDK.Object, cnrID cid.ID) (*user.ID, *keys.PublicKey, error) {
if !st.AssertContainer(cnrID) {
func (ac *apeChecker) getActorAndPKFromSessionToken(st *sessionSDK.Container, cnrID cid.ID) (*user.ID, *keys.PublicKey, error) {
if cnrID != undefinedContainerID && !st.AppliedTo(cnrID) {
dstepanov-yadro commented 2024-01-10 15:41:13 +00:00
Author
Member
Copy link

Like by innerring:

Line 113 in 79bebe4
if v.idContainerSet && !tok.AppliedTo(v.idContainer) {

Like by innerring: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/79bebe4a683ceab420742577a46bfc536bc2e118/pkg/innerring/processors/container/common.go#L113
dstepanov-yadro requested review from storage-core-committers 2024-01-10 15:41:32 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-01-10 15:41:36 +00:00
aarifullin approved these changes 2024-01-11 06:06:45 +00:00
dkirillov approved these changes 2024-01-11 06:34:45 +00:00
acid-ant approved these changes 2024-01-11 07:09:10 +00:00
fyrchik approved these changes 2024-01-11 07:19:47 +00:00
fyrchik commented 2024-01-11 07:20:28 +00:00
Owner
Copy link

Failing test is #896

Failing test is https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/896
fyrchik merged commit 5c0a736a25 into master 2024-01-11 07:20:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
dkirillov
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#900
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/create_container_session_context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?