TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

control: Take empty namespace for 'root' #910

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/control-svc-root-ns into master 2024-01-19 06:22:13 +00:00
Conversation 1 Commits 1 Files changed 1 +6 -1
aarifullin commented 2024-01-12 14:57:49 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed fix/control-svc-root-ns from f2820071c6 to abf34b3b88 2024-01-12 14:58:18 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-01-12 14:58:23 +00:00
aarifullin requested review from storage-core-developers 2024-01-12 14:58:30 +00:00
dstepanov-yadro approved these changes 2024-01-12 15:00:37 +00:00
acid-ant approved these changes 2024-01-12 15:01:30 +00:00
fyrchik commented 2024-01-12 16:13:40 +00:00
Owner
Copy link

All tests are failing

All tests are failing
fyrchik approved these changes 2024-01-15 06:42:16 +00:00
fyrchik approved these changes 2024-01-16 13:58:41 +00:00
pkg/services/control/server/policy_engine.go Outdated
@ -19,2 +19,3 @@
case control.ChainTarget_NAMESPACE:
return engine.NamespaceTarget(chainTarget.GetName()), nil
namespace := chainTarget.GetName()
// if namespace is empty, we take it for root namespace.
fyrchik commented 2024-01-16 13:58:39 +00:00
Owner
Copy link

If it ends with ., it should start with a capital letter.

If it ends with `.`, it should start with a capital letter.
aarifullin commented 2024-01-16 14:45:12 +00:00
Author
Member
Copy link

Fixed! 👌

Fixed! 👌
aarifullin force-pushed fix/control-svc-root-ns from abf34b3b88 to 1bbfe186ae 2024-01-16 14:44:49 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2024-01-16 14:45:24 +00:00
aarifullin requested review from acid-ant 2024-01-16 14:45:24 +00:00
aarifullin requested review from fyrchik 2024-01-16 14:45:24 +00:00
dstepanov-yadro approved these changes 2024-01-18 18:46:29 +00:00
fyrchik merged commit be33070550 into master 2024-01-19 06:22:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#910
No description provided.
Delete branch "aarifullin/frostfs-node:fix/control-svc-root-ns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?