TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

control: Take empty namespace for 'root' #910

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/control-svc-root-ns into master 2024-01-19 06:22:13 +00:00
Conversation 1 Commits 1 Files changed 1 +6 -1
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/control/server/policy_engine.go
View file

@ -17,7 +17,12 @@ func apeTarget(chainTarget *control.ChainTarget) (engine.Target, error) {
case control.ChainTarget_CONTAINER: case control.ChainTarget_CONTAINER:
return engine.ContainerTarget(chainTarget.GetName()), nil return engine.ContainerTarget(chainTarget.GetName()), nil
case control.ChainTarget_NAMESPACE: case control.ChainTarget_NAMESPACE:
return engine.NamespaceTarget(chainTarget.GetName()), nil namespace := chainTarget.GetName()
// If namespace is empty, we take it for root namespace.
fyrchik commented 2024-01-16 13:58:39 +00:00
Outdated
Review
Copy link

If it ends with ., it should start with a capital letter.

If it ends with `.`, it should start with a capital letter.
aarifullin commented 2024-01-16 14:45:12 +00:00
Outdated
Review
Copy link

Fixed! 👌

Fixed! 👌
if namespace == "" {
namespace = "root"
}
return engine.NamespaceTarget(namespace), nil
default: default:
} }
return engine.Target{}, status.Error(codes.InvalidArgument, return engine.Target{}, status.Error(codes.InvalidArgument,