TrueCloudLab/frostfs-node

morph: Provide batch size for container listing explicitly #931

Merged

fyrchik merged 1 commit from fyrchik/frostfs-node:fix-iterator into master

2024-01-29 14:00:13 +00:00

fyrchik commented

2024-01-25 08:19:06 +00:00

Owner

Besides VM stack item limit we also have restrictions on the size of
JSON for a stackitem, which is 128k. This limit is much harder to
calculate, because JSON representation includes type and the encoding is
different for different items. Thus is makes no sense to invent our own
default, so use the one provided by neo-go. But for container listing we
know exactly what we process, so use big enough value, which is tested.

Introduced in be8607a1f6.

Refs #902
Refs https://github.com/nspcc-dev/neo-go/blob/v0.105.0/pkg/vm/stackitem/json.go#L353

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Besides VM stack item limit we also have restrictions on the size of JSON for a stackitem, which is 128k. This limit is much harder to calculate, because JSON representation includes type and the encoding is different for different items. Thus is makes no sense to invent our own default, so use the one provided by neo-go. But for container listing we know exactly what we process, so use big enough value, which is tested. Introduced in be8607a1f6. Refs #902 Refs https://github.com/nspcc-dev/neo-go/blob/v0.105.0/pkg/vm/stackitem/json.go#L353 Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added the

labels 2024-01-25 08:19:06 +00:00

fyrchik requested review from storage-core-committers 2024-01-25 08:20:03 +00:00

fyrchik requested review from storage-core-developers 2024-01-25 08:20:19 +00:00

fyrchik force-pushed fix-iterator from 02cf2b65de to f8013f3031

2024-01-25 08:20:28 +00:00

Compare

fyrchik added this to the v0.38.0 milestone 2024-01-25 08:21:10 +00:00

fyrchik force-pushed fix-iterator from f8013f3031 to 7502b9f07a

2024-01-25 08:21:15 +00:00

Compare

acid-ant approved these changes 2024-01-25 09:22:58 +00:00

dstepanov-yadro approved these changes 2024-01-29 13:33:02 +00:00

aarifullin approved these changes 2024-01-29 13:35:56 +00:00

fyrchik merged commit df055fead5 into master

2024-01-29 14:00:13 +00:00

fyrchik referenced this pull request from a commit

2024-01-29 14:00:14 +00:00

[#931] morph: Provide batch size for container listing explicitly

fyrchik deleted branch fix-iterator

2024-01-29 14:00:14 +00:00

fyrchik referenced this pull request

2024-02-21 12:30:35 +00:00

morph: Fix batch size in TraverseIterator() #1000

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#931

No description provided.