TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Support reloading service pool sizes on SIGHUP #956

Merged
fyrchik merged 4 commits from fyrchik/frostfs-node:reload-pools into master 2024-02-08 15:49:45 +00:00
Conversation 0 Commits 4 Files changed 6 +43 -35
fyrchik commented 2024-02-02 17:43:31 +00:00
Owner
Copy link

Restarting services is very slow (and induces effects on other nodes), supporting SIGHUP is easy.

Tested on dev-env:

2024-02-02T17:40:58.632Z        info    frostfs-node/config.go:1299     adjust pool configuration      {"field": "object.put.local_pool_size", "old": 10, "new": 123}
2024-02-02T17:40:58.632Z        info    frostfs-node/config.go:1299     adjust pool configuration      {"field": "object.put.remote_pool_size", "old": 10, "new": 321}
Restarting services is very slow (and induces effects on other nodes), supporting SIGHUP is easy. Tested on dev-env: ``` 2024-02-02T17:40:58.632Z info frostfs-node/config.go:1299 adjust pool configuration {"field": "object.put.local_pool_size", "old": 10, "new": 123} 2024-02-02T17:40:58.632Z info frostfs-node/config.go:1299 adjust pool configuration {"field": "object.put.remote_pool_size", "old": 10, "new": 321} ```
fyrchik force-pushed reload-pools from e6574ed569 to b3e7d50be6 2024-02-02 17:43:58 +00:00 Compare
fyrchik reviewed 2024-02-02 17:46:31 +00:00
cmd/frostfs-node/config.go Outdated
@ -1288,0 +1293,4 @@
return nil
}
func (c *cfg) reloadPool(p *ants.Pool, newSize int, name string) {
fyrchik commented 2024-02-02 17:46:25 +00:00
Author
Owner
Copy link

I am not a fan of such small functions, but it helps to avoid forgetting to change something after copypaste

I am not a fan of such small functions, but it helps to avoid forgetting to change something after copypaste
fyrchik force-pushed reload-pools from b3e7d50be6 to 4e33b4a417 2024-02-02 17:58:07 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-02-02 17:58:12 +00:00
fyrchik requested review from storage-core-developers 2024-02-02 17:58:14 +00:00
acid-ant approved these changes 2024-02-05 06:13:42 +00:00
aarifullin approved these changes 2024-02-08 09:13:31 +00:00
dstepanov-yadro approved these changes 2024-02-08 13:00:47 +00:00
fyrchik merged commit 805862f4b7 into master 2024-02-08 15:49:45 +00:00
fyrchik deleted branch reload-pools 2024-02-08 15:49:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#956
No description provided.
Delete branch "fyrchik/frostfs-node:reload-pools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?