Drop GC marks if object not found #964

Merged

fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/drop_gc_marks_next_part into master

2024-02-08 07:54:40 +00:00

dstepanov-yadro commented

2024-02-06 16:27:14 +00:00

Member

It can be situation when metabase has GC mark, but doesn't have object.
So metabase.Delete must delete GC mark in such situation.

It can be situation when metabase has GC mark, but doesn't have object. So `metabase.Delete` must delete GC mark in such situation.

dstepanov-yadro force-pushed fix/drop_gc_marks_next_part from 991a8477ca to 2ebaec8f94

2024-02-06 16:28:14 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2024-02-06 16:42:02 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-02-06 16:42:04 +00:00

fyrchik commented

2024-02-06 17:45:22 +00:00

Owner

How does this situation occur exactly? Could you describe it in the commit message too?.
It could be the case for zombie apocalypse if done carelessly.

How does this situation occur exactly? Could you describe it in the commit message too?. It could be the case for zombie apocalypse if done carelessly.

dstepanov-yadro force-pushed fix/drop_gc_marks_next_part from 2ebaec8f94 to 4f3ebb1d8c

2024-02-07 06:59:32 +00:00

Compare

dstepanov-yadro commented

2024-02-07 07:01:24 +00:00

Author

Member

How does this situation occur exactly? Could you describe it in the commit message too?.
It could be the case for zombie apocalypse if done carelessly.

Done. GC inhumes expired locks and tombstones on all the shards.

> How does this situation occur exactly? Could you describe it in the commit message too?. > It could be the case for zombie apocalypse if done carelessly. Done. GC inhumes expired locks and tombstones on all the shards.

dstepanov-yadro force-pushed fix/drop_gc_marks_next_part from 4f3ebb1d8c to 4bea183729

2024-02-07 07:02:05 +00:00

Compare

fyrchik approved these changes 2024-02-07 16:08:33 +00:00

dstepanov-yadro force-pushed fix/drop_gc_marks_next_part from 4bea183729 to bf1011131a

2024-02-08 07:29:13 +00:00

Compare