TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

node: Set mode to shard's components when open it #967

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/959-init-with-mode into master 2024-02-09 14:04:03 +00:00
Conversation 1 Commits 1 Files changed 25 +219 -74
acid-ant commented 2024-02-07 14:38:56 +00:00
Member
Copy link

Close #959

Avoid opening database for metabase and cache in Degraded mode.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #959 Avoid opening database for `metabase` and `cache` in `Degraded` mode. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-02-07 14:39:11 +00:00
acid-ant requested review from storage-core-developers 2024-02-07 14:39:16 +00:00
fyrchik requested changes 2024-02-07 16:08:17 +00:00
pkg/local_object_storage/blobstor/blobstor_test.go Outdated
@ -267,6 +271,7 @@ func TestConcurrentDelete(t *testing.T) {
const smallSizeLimit = 512
blobStor := New(
mode.ReadWrite,
fyrchik commented 2024-02-07 16:08:07 +00:00
Owner
Copy link

It is necessary to put this inNew()? It doesn't accepts such things by design, because
they are provided in Open (where ro bool parameter can be replaced with m mode.Mode I guess)

It is necessary to put this in`New()`? It doesn't accepts such things by design, because they are provided in `Open` (where `ro bool` parameter can be replaced with `m mode.Mode` I guess)
👍 1
acid-ant commented 2024-02-08 05:52:50 +00:00
Author
Member
Copy link

No, it is not necessary. But in this case, we need to store mode inside Open, except when Open executed from SetMode.

No, it is not necessary. But in this case, we need to store `mode` inside `Open`, except when `Open` executed from `SetMode`.
acid-ant commented 2024-02-09 06:19:48 +00:00
Author
Member
Copy link

Updated, now mode propagated via Open.

Updated, now `mode` propagated via `Open`.
dstepanov-yadro requested changes 2024-02-08 12:57:58 +00:00
cmd/frostfs-lens/internal/meta/root.go Outdated
@ -36,6 +37,7 @@ func init() {
func openMeta(cmd *cobra.Command) *meta.DB {
db := meta.New(
mode.ReadWrite,
dstepanov-yadro commented 2024-02-08 12:57:00 +00:00
Member
Copy link

Here metabase must be open read-only, see lines below.

Here metabase must be open read-only, see lines below.
fyrchik commented 2024-02-08 17:37:06 +00:00
Owner
Copy link

Another reason to provide mode in Open -- this avoids duplication and inconsistence.

Another reason to provide mode in `Open` -- this avoids duplication and inconsistence.
acid-ant commented 2024-02-09 06:20:06 +00:00
Author
Member
Copy link

Thanks, fixed.

Thanks, fixed.
acid-ant force-pushed bugfix/959-init-with-mode from e5dd857474 to 5164ec6f67 2024-02-09 06:18:52 +00:00 Compare
acid-ant requested review from fyrchik 2024-02-09 06:20:24 +00:00
acid-ant requested review from dstepanov-yadro 2024-02-09 06:20:24 +00:00
acid-ant changed title from node: Set mode to shard's components when created to node: Set mode to shard's components when open it 2024-02-09 06:23:34 +00:00
fyrchik approved these changes 2024-02-09 07:38:14 +00:00
pkg/local_object_storage/shard/id.go Outdated
@ -38,2 +36,2 @@
} else {
metabaseOpened = true
m := s.GetMode()
if !m.NoMetabase() {
fyrchik commented 2024-02-09 07:37:55 +00:00
Owner
Copy link

No when the mode is provided to Open(), do we still need this if? It seems metabase knows to do nothing in Degraded mode.

No when the mode is provided to Open(), do we still need this if? It seems metabase knows to do nothing in Degraded mode.
acid-ant commented 2024-02-09 09:29:02 +00:00
Author
Member
Copy link

Thanks, simplified this part.

Thanks, simplified this part.
dstepanov-yadro requested changes 2024-02-09 08:18:44 +00:00
dstepanov-yadro left a comment
Member
Copy link

Some unit test required

Some unit test required
acid-ant force-pushed bugfix/959-init-with-mode from 5164ec6f67 to 29812f6683 2024-02-09 09:28:04 +00:00 Compare
acid-ant commented 2024-02-09 09:29:45 +00:00
Author
Member
Copy link

Some unit test required

Thanks, added.

> Some unit test required Thanks, added.
acid-ant requested review from dstepanov-yadro 2024-02-09 09:29:51 +00:00
dstepanov-yadro approved these changes 2024-02-09 09:33:45 +00:00
fyrchik merged commit d19ade23c8 into master 2024-02-09 14:04:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#967
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/959-init-with-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?