TrueCloudLab/frostfs-node

adm: Introduce flag `chain-name` for APE managing commands #982

Merged

fyrchik merged 1 commit from acid-ant/frostfs-node:feature/980-chain-name into master

2024-02-14 07:28:10 +00:00

acid-ant commented

2024-02-13 13:25:13 +00:00

Member

Close #980

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #980 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant requested review from storage-core-committers 2024-02-13 13:25:23 +00:00

acid-ant requested review from storage-core-developers 2024-02-13 13:25:24 +00:00

dstepanov-yadro approved these changes 2024-02-13 14:43:01 +00:00

fyrchik reviewed 2024-02-14 06:33:33 +00:00

cmd/frostfs-adm/internal/modules/morph/ape/ape.go Outdated

					
				@ -100,6 +102,9 @@ func initAddRuleChainCmd() {

					addRuleChainCmd.Flags().String(ruleFlag, "", ruleFlagDesc)

					addRuleChainCmd.Flags().String(ruleJSONFlag, "", ruleJSONFlagDesc)

					addRuleChainCmd.Flags().String(chainNameFlag, "", chainNameFlagDesc)

fyrchik commented

2024-02-14 06:33:03 +00:00

Owner

It should not be required and the default should be ingress.
If we can avoid mandatory parameters in a sane way, we should.

It should not be required and the default should be `ingress`. If we can avoid mandatory parameters in a sane way, we should.

acid-ant commented

2024-02-14 06:42:49 +00:00

Author

Member

Agree, updated.

Agree, updated.

acid-ant force-pushed feature/980-chain-name from f07ab89f62 to 5cbf57081f

2024-02-14 06:42:13 +00:00

Compare

fyrchik approved these changes 2024-02-14 07:28:02 +00:00

fyrchik merged commit 5cbf57081f into master

2024-02-14 07:28:10 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#982

No description provided.