TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

writecache: Avoid manipulation with cache in DEGRADED mode #998

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/959-init-fstree-degraded into master 2024-03-11 18:35:43 +00:00
Conversation 0 Commits 1 Files changed 6 +35 -1
acid-ant commented 2024-02-20 14:27:29 +00:00
Member
Copy link

Close #959

Avoid manipulation with cache in DEGRADED mode.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #959 Avoid manipulation with cache in `DEGRADED` mode. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
dstepanov-yadro approved these changes 2024-02-20 15:02:51 +00:00
fyrchik reviewed 2024-02-20 15:09:15 +00:00
pkg/local_object_storage/writecache/storage.go Outdated
@ -58,3 +59,3 @@
fstree.WithFileCounter(&c.objCounters),
)
if err := c.fsTree.Open(readOnly); err != nil {
if err := c.fsTree.Open(mode.ReadOnly()); err != nil {
fyrchik commented 2024-02-20 15:09:15 +00:00
Owner
Copy link

It should not be like this, degraded means we do not touch anything at all, like with the DB
The problem is that requests still get to fstree -- we should check mode for all operations like we do in other places (see e.g. pilorama https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/pilorama/boltdb.go#L197 )

It should not be like this, degraded means we do not touch anything at all, like with the DB The problem is that requests still get to fstree -- we should check mode for all operations like we do in other places (see e.g. pilorama https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/pilorama/boltdb.go#L197 )
acid-ant commented 2024-02-22 15:31:52 +00:00
Author
Member
Copy link

Added check for mode to writecache. Tested in dev-env with k6.

Added check for `mode` to `writecache`. Tested in dev-env with k6.
aarifullin approved these changes 2024-02-21 08:42:05 +00:00
acid-ant force-pushed bugfix/959-init-fstree-degraded from 632930c7b1 to e69a3128dc 2024-02-22 15:30:29 +00:00 Compare
acid-ant force-pushed bugfix/959-init-fstree-degraded from e69a3128dc to d86842e80a 2024-02-26 06:33:34 +00:00 Compare
aarifullin approved these changes 2024-02-26 09:03:30 +00:00
fyrchik reviewed 2024-02-28 19:03:49 +00:00
pkg/local_object_storage/writecache/storage.go Outdated
@ -58,3 +59,3 @@
fstree.WithFileCounter(&c.objCounters),
)
if err := c.fsTree.Open(readOnly); err != nil {
if err := c.fsTree.Open(mode.ReadOnly()); err != nil {
fyrchik commented 2024-02-28 19:03:49 +00:00
Owner
Copy link

Again, why do we need to create and open fstree?
It should be nil in degraded.

Again, why do we need to create and open fstree? It should be nil in degraded.
acid-ant commented 2024-03-05 08:35:59 +00:00
Author
Member
Copy link

Fixed. Tested in dev-env.

Fixed. Tested in dev-env.
acid-ant force-pushed bugfix/959-init-fstree-degraded from d86842e80a to c97c0a7105 2024-03-01 10:50:53 +00:00 Compare
acid-ant force-pushed bugfix/959-init-fstree-degraded from c97c0a7105 to 9021b5af72 2024-03-04 19:27:12 +00:00 Compare
acid-ant changed title from writecache: Initialize fstree in DEGRADED mode to writecache: Avoid manipulation with cache in DEGRADED mode 2024-03-04 19:27:56 +00:00
acid-ant changed title from writecache: Avoid manipulation with cache in DEGRADED mode to WIP: writecache: Avoid manipulation with cache in DEGRADED mode 2024-03-04 19:29:05 +00:00
acid-ant force-pushed bugfix/959-init-fstree-degraded from 9021b5af72 to 56b358cb34 2024-03-05 08:26:15 +00:00 Compare
acid-ant changed title from WIP: writecache: Avoid manipulation with cache in DEGRADED mode to writecache: Avoid manipulation with cache in DEGRADED mode 2024-03-05 08:29:15 +00:00
acid-ant requested review from dstepanov-yadro 2024-03-05 08:29:19 +00:00
acid-ant requested review from aarifullin 2024-03-05 08:29:21 +00:00
acid-ant requested review from fyrchik 2024-03-05 08:29:38 +00:00
acid-ant requested review from storage-core-developers 2024-03-05 08:29:39 +00:00
acid-ant force-pushed bugfix/959-init-fstree-degraded from 56b358cb34 to 3960570b77 2024-03-05 08:30:17 +00:00 Compare
fyrchik reviewed 2024-03-05 08:54:57 +00:00
pkg/local_object_storage/writecache/storage.go
@ -27,3 +28,3 @@
func (c *cache) openStore(readOnly bool) error {
func (c *cache) openStore(mode mode.Mode) error {
err := util.MkdirAllX(c.path, os.ModePerm)
fyrchik commented 2024-03-05 08:54:57 +00:00
Owner
Copy link

Now we do this in degraded mode.
Can we move mode.NoMetabase check outside the function as it was? The whole function doesn't need to be executed.

Now we do this in degraded mode. Can we move `mode.NoMetabase` check outside the function as it was? The whole function doesn't need to be executed.
acid-ant commented 2024-03-05 11:31:00 +00:00
Author
Member
Copy link

Agree, looks ugly, reverted.

Agree, looks ugly, reverted.
acid-ant force-pushed bugfix/959-init-fstree-degraded from 3960570b77 to 9033e6c782 2024-03-05 11:26:01 +00:00 Compare
acid-ant force-pushed bugfix/959-init-fstree-degraded from 9033e6c782 to eecaed5b4b 2024-03-05 11:29:13 +00:00 Compare
acid-ant force-pushed bugfix/959-init-fstree-degraded from eecaed5b4b to f6f327b5dc 2024-03-05 12:00:23 +00:00 Compare
dstepanov-yadro approved these changes 2024-03-06 08:27:50 +00:00
fyrchik approved these changes 2024-03-11 18:35:35 +00:00
fyrchik merged commit 3195142d67 into master 2024-03-11 18:35:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#998
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/959-init-fstree-degraded"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?