TrueCloudLab/frostfs-observability
21
0
Fork 10
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

config: Add resource attributes #17

Merged
fyrchik merged 1 commit from feat/tracing_attributes into master 2024-11-12 08:45:10 +00:00
Conversation 1 Commits 1 Files changed 2 +9 -1
dstepanov-yadro commented 2024-11-12 08:20:35 +00:00
Member
Copy link

This allows to specify key-value attributes for all spans.
I think it is ok to limit value types with string, as other types could be converted to string by service.

Example:
image

This allows to specify key-value attributes for all spans. I think it is ok to limit value types with `string`, as other types could be converted to `string` by service. Example: ![image](/attachments/f092a8f7-8b4a-4e75-9cef-1bebaba3016f)
image.png
197 KiB
dstepanov-yadro added 1 commit 2024-11-12 08:20:35 +00:00
[#9999] config: Add resource attributes
All checks were successful
DCO action / DCO (pull_request) Successful in 1m21s
Details
Tests and linters / Tests (pull_request) Successful in 1m37s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m41s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m23s
Details
Tests and linters / Lint (pull_request) Successful in 3m1s
Details
651f797671 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/tracing_attributes from 651f797671 to a2e94b5bb6 2024-11-12 08:21:31 +00:00 Compare
dstepanov-yadro force-pushed feat/tracing_attributes from a2e94b5bb6 to f17779933e 2024-11-12 08:23:30 +00:00 Compare
dstepanov-yadro commented 2024-11-12 08:25:14 +00:00
Author
Member
Copy link

Oh, sorry, I have pushed my branch to this repo but not to fork. I delete branch on this repo after merge.

Oh, sorry, I have pushed my branch to this repo but not to fork. I delete branch on this repo after merge.
dstepanov-yadro requested review from storage-core-committers 2024-11-12 08:28:03 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-11-12 08:28:03 +00:00
dstepanov-yadro requested review from alexvanin 2024-11-12 08:28:11 +00:00
acid-ant approved these changes 2024-11-12 08:41:14 +00:00
dstepanov-yadro reviewed 2024-11-12 08:43:13 +00:00
tracing/setup.go
@ -165,1 +165,4 @@
for k, v := range cfg.Attributes {
attrs = append(attrs, attribute.String(k, v))
}
return resource.NewWithAttributes(
dstepanov-yadro commented 2024-11-12 08:43:13 +00:00
Author
Member
Copy link

resource.NewWithAttributes performs attributes validation

`resource.NewWithAttributes` performs attributes validation
fyrchik approved these changes 2024-11-12 08:44:50 +00:00
fyrchik merged commit f17779933e into master 2024-11-12 08:45:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-observability#17
No description provided.
Delete branch "feat/tracing_attributes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?