TrueCloudLab/frostfs-qos
14
0
Fork 5
Code Issues 1 Pull requests Projects Releases Packages Activity Actions

Tagging #2

Merged
dstepanov-yadro merged 2 commits from dstepanov-yadro/frostfs-qos:feat/tagging into master 2025-01-28 11:34:10 +00:00
Conversation 0 Commits 2 Files changed 6 +193 -1
dstepanov-yadro commented 2025-01-21 09:26:02 +00:00
Member
Copy link

Add methods to set/get IO tag from context.Context and grpc.Metadata

Add methods to set/get IO tag from `context.Context` and `grpc.Metadata`
dstepanov-yadro added 5 commits 2025-01-21 09:26:02 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#1] Makefile: Create directory with parents
Some checks failed
DCO action / DCO (pull_request) Successful in 30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 37s
Details
Tests and linters / Staticcheck (pull_request) Successful in 45s
Details
Pre-commit hooks / Pre-commit (pull_request) Failing after 52s
Details
Tests and linters / Lint (pull_request) Successful in 1m4s
Details
Tests and linters / Tests (pull_request) Successful in 1m9s
Details
Tests and linters / gopls check (pull_request) Successful in 1m15s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m40s
Details
95ccf46c64 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#1] pre-commit: Use local golangci-lint hook
All checks were successful
DCO action / DCO (pull_request) Successful in 28s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 40s
Details
Tests and linters / Lint (pull_request) Successful in 1m4s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m12s
Details
Tests and linters / Tests (pull_request) Successful in 1m18s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m19s
Details
Tests and linters / gopls check (pull_request) Successful in 1m24s
Details
c6789eea71 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#2] Add CODEOWNERS
Some checks failed
DCO action / DCO (pull_request) Successful in 27s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 29s
Details
Vulncheck / Vulncheck (pull_request) Successful in 37s
Details
Tests and linters / Tests (pull_request) Successful in 45s
Details
Tests and linters / Tests with -race (pull_request) Successful in 50s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m3s
Details
Pre-commit hooks / Pre-commit (pull_request) Failing after 1m29s
Details
Tests and linters / Lint (pull_request) Successful in 1m35s
Details
Tests and linters / gopls check (pull_request) Successful in 1m37s
Details
c208b6d71d 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/tagging from c208b6d71d to 9c7de1765c 2025-01-21 09:40:09 +00:00 Compare
dstepanov-yadro force-pushed feat/tagging from 9c7de1765c to 678400574e 2025-01-24 13:01:57 +00:00 Compare
dstepanov-yadro added 1 commit 2025-01-24 13:03:23 +00:00
[#2] Makefile: Create directory with parents
Some checks failed
DCO action / DCO (pull_request) Successful in 27s
Details
Tests and linters / Tests with -race (pull_request) Successful in 31s
Details
Vulncheck / Vulncheck (pull_request) Successful in 36s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 37s
Details
Pre-commit hooks / Pre-commit (pull_request) Failing after 48s
Details
Tests and linters / Tests (pull_request) Successful in 48s
Details
Tests and linters / Staticcheck (pull_request) Successful in 50s
Details
Tests and linters / Lint (pull_request) Successful in 1m20s
Details
Tests and linters / gopls check (pull_request) Successful in 1m55s
Details
455d6ac42e 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro added 1 commit 2025-01-24 13:06:56 +00:00
[#2] pre-commit: Use local golangci-lint hook
All checks were successful
DCO action / DCO (pull_request) Successful in 28s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 36s
Details
Vulncheck / Vulncheck (pull_request) Successful in 37s
Details
Tests and linters / Staticcheck (pull_request) Successful in 49s
Details
Tests and linters / Lint (pull_request) Successful in 1m12s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m20s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m21s
Details
Tests and linters / gopls check (pull_request) Successful in 1m36s
Details
Tests and linters / Tests (pull_request) Successful in 1m41s
Details
6683cb983f 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro changed title from WIP: Add tagging to Tagging 2025-01-24 13:10:39 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-01-24 13:10:46 +00:00
aarifullin reviewed 2025-01-24 14:20:33 +00:00
tagging/context.go Outdated
@ -0,0 +2,4 @@
import "context"
type tagContextKeyType int
aarifullin commented 2025-01-24 14:20:33 +00:00
Member
Copy link

Using int/string as a key within Context may cause some problems. You should introduce:

type tagContextKeyType struct{}

var currentTagKey = tagContextKeyType{}

You can check this out

Using `int`/`string` as a key within `Context` may cause some problems. You should introduce: ```go type tagContextKeyType struct{} var currentTagKey = tagContextKeyType{} ``` You can check [this](https://gist.github.com/ww9/4ad7b2ddfb94816a30dfdf2218e02f48) out
dstepanov-yadro commented 2025-01-24 14:36:00 +00:00
Author
Member
Copy link

Details:

	// This also applies to int keys. Same type means equal:
	compareKeys(IntKey1(0), IntKey1(0)) // true
	// And different keys are never equal even though they have 0 value:
	compareKeys(IntKey1(0), IntKey2(0)) // false
	// However, unlike struct{}, an int typed key allows for mistakes with the value:
	compareKeys(IntKey1(0), IntKey1(1)) // false
	// To add to why you shouldn't use int typed keys, when seeing that the package define a
	// key as int, the user might be tempted to pass a primitive 0 instead. Which doesn't work:
	compareKeys(IntKey1(0), 0) // false

But tagContextKeyType is internal as const currentTagKey tagContextKeyType = iota

Details: ``` // This also applies to int keys. Same type means equal: compareKeys(IntKey1(0), IntKey1(0)) // true // And different keys are never equal even though they have 0 value: compareKeys(IntKey1(0), IntKey2(0)) // false // However, unlike struct{}, an int typed key allows for mistakes with the value: compareKeys(IntKey1(0), IntKey1(1)) // false // To add to why you shouldn't use int typed keys, when seeing that the package define a // key as int, the user might be tempted to pass a primitive 0 instead. Which doesn't work: compareKeys(IntKey1(0), 0) // false ``` But `tagContextKeyType` is internal as `const currentTagKey tagContextKeyType = iota`
aarifullin commented 2025-01-24 14:49:53 +00:00
Member
Copy link

My initial concern was about whether currentTagKey overrides currentTagKeyFromSomeOtherPackageWithTheSameIOTA. I checked it on my own: it's fine, context keeps two keys. So, nevermind!

My initial concern was about whether `currentTagKey ` overrides `currentTagKeyFromSomeOtherPackageWithTheSameIOTA`. I checked it on my own: it's fine, context keeps two keys. So, nevermind!
aarifullin marked this conversation as resolved
aarifullin approved these changes 2025-01-24 14:50:24 +00:00
aarifullin left a comment
Member
Copy link

👍

👍
fyrchik approved these changes 2025-01-28 11:21:15 +00:00
elebedeva approved these changes 2025-01-28 11:29:19 +00:00
dstepanov-yadro force-pushed feat/tagging from 6683cb983f to 128933fade 2025-01-28 11:29:54 +00:00 Compare
dstepanov-yadro merged commit 128933fade into master 2025-01-28 11:34:10 +00:00
dstepanov-yadro referenced this pull request from a commit 2025-01-28 11:34:11 +00:00
[#2] Add CODEOWNERS
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
elebedeva
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-qos#2
No description provided.
Delete branch "dstepanov-yadro/frostfs-qos:feat/tagging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?