TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 18 Pull requests 4 Projects Releases 36 Packages 1 Activity Actions

[#328] Log error on failed response writing
Some checks failed
/ DCO (pull_request) Successful in 3m34s
Details
/ Vulncheck (pull_request) Failing after 4m18s
Details
/ Builds (1.20) (pull_request) Successful in 4m58s
Details
/ Builds (1.21) (pull_request) Successful in 4m24s
Details
/ Lint (pull_request) Successful in 7m27s
Details
/ Tests (1.20) (pull_request) Successful in 5m24s
Details
/ Tests (1.21) (pull_request) Successful in 5m0s
Details

Browse source 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
This commit is contained in:
Denis Kirillov 2024-03-04 15:53:00 +03:00
parent 6788306998
commit 62cc5a04a7
10 changed files with 94 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

7
api/handler/util.go
View file

@ -31,9 +31,12 @@ func (h *handler) reqLogger(ctx context.Context) *zap.Logger {
func (h *handler) logAndSendError(w http.ResponseWriter, logText string, reqInfo *middleware.ReqInfo, err error, additional ...zap.Field) {
err = handleDeleteMarker(w, err)
code := middleware.WriteErrorResponse(w, reqInfo, transformToS3Error(err))
if code, wrErr := middleware.WriteErrorResponse(w, reqInfo, transformToS3Error(err)); wrErr != nil {
additional = append(additional, zap.NamedError("write_response_error", wrErr))
} else {
additional = append(additional, zap.Int("status", code))
}
fields := []zap.Field{
zap.Int("status", code),
zap.String("request_id", reqInfo.RequestID),
zap.String("method", reqInfo.API),
zap.String("bucket", reqInfo.BucketName),