Don't ignore errors completely #328

New Issue

Closed

opened 2024-03-04 08:29:23 +00:00 by dkirillov · 0 comments

dkirillov commented

2024-03-04 08:29:23 +00:00

Collaborator

There are several places: 1, 2, 3 and some others where we ignore errors completely. It will be hard to known what went wrong without proper error handling.

Describe the solution you'd like

We should at least log errors in such cases.

Describe alternatives you've considered

Handle error and fail request

Additional context

Places without error handling were found by Svace

## Is your feature request related to a problem? Please describe. There are several places: [1](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/8050ca2d517ebfd64e33764c137f86b703611146/api/handler/put.go#L1101), [2](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/8050ca2d517ebfd64e33764c137f86b703611146/pkg/service/tree/tree.go#L249), [3](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/8050ca2d517ebfd64e33764c137f86b703611146/api/middleware/response.go#L176) and some others where we ignore errors completely. It will be hard to known what went wrong without proper error handling. ## Describe the solution you'd like We should at least log errors in such cases. ## Describe alternatives you've considered Handle error and fail request ## Additional context Places without error handling were found by Svace