TrueCloudLab/frostfs-s3-gw
14
2
Fork 17
Code Issues 21 Pull requests 4 Projects Releases 15 Packages Activity Actions

feature/328-add_log_ignored_errors #330

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/328-add_log_ignored_errors into master 2024-09-04 19:51:13 +00:00
Conversation 0 Commits 1 Files changed 10 +94 -34
dkirillov commented 2024-03-04 12:59:04 +00:00
Member
Copy link

close #328

close #328
dkirillov self-assigned this 2024-03-04 12:59:04 +00:00
dkirillov added 2 commits 2024-03-04 12:59:07 +00:00 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-committers 2024-03-04 13:01:35 +00:00
dkirillov requested review from storage-services-developers 2024-03-04 13:01:37 +00:00
dkirillov force-pushed feature/328-add_log_ignored_errors from 8e27880f50 to 6e10f7ad90 2024-03-04 13:17:40 +00:00 Compare
mbiryukova reviewed 2024-03-13 15:10:02 +00:00
api/handler/util.go Outdated
@ -34,3 +34,3 @@
code := middleware.WriteErrorResponse(w, reqInfo, transformToS3Error(err))
code, wrErr := middleware.WriteErrorResponse(w, reqInfo, transformToS3Error(err))
fields := []zap.Field{
zap.Int("status", code),
mbiryukova commented 2024-03-13 15:10:02 +00:00
Member
Copy link

Is it ok to log 0 in case of write response error?

Is it ok to log `0` in case of write response error?
👍 1
dkirillov force-pushed feature/328-add_log_ignored_errors from 6e10f7ad90 to 9ff8c2afd7 2024-03-15 07:54:32 +00:00 Compare
dkirillov force-pushed feature/328-add_log_ignored_errors from 9ff8c2afd7 to 462dde649e 2024-03-15 07:57:20 +00:00 Compare
dkirillov force-pushed feature/328-add_log_ignored_errors from 462dde649e to dc08a4feb8 2024-03-15 08:00:44 +00:00 Compare
dkirillov force-pushed feature/328-add_log_ignored_errors from dc08a4feb8 to 9b94bf7097 2024-03-15 08:01:27 +00:00 Compare
dkirillov force-pushed feature/328-add_log_ignored_errors from 9b94bf7097 to 62cc5a04a7 2024-03-15 08:02:45 +00:00 Compare
alexvanin approved these changes 2024-03-15 09:41:03 +00:00
alexvanin merged commit 62cc5a04a7 into master 2024-03-15 09:41:10 +00:00
alexvanin deleted branch feature/328-add_log_ignored_errors 2024-03-15 09:41:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#330
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/328-add_log_ignored_errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?