Improve tree node switching #115

dkirillov · 2023-05-19T14:12:11Z

dkirillov commented

2023-05-19 14:12:11 +00:00

Log tree method and request id on retry.
Switch on any errors but not found and access denied
Add redial for unhealthy tree clients

close #110
close #114

Log tree method and request id on retry. Switch on any errors but `not found` and `access denied` Add redial for unhealthy tree clients close #110 close #114

dkirillov self-assigned this 2023-05-19 14:12:11 +00:00

dkirillov added 2 commits 2023-05-19 14:12:12 +00:00

8b41fbeed0 [#110 ] tree: Update errors to switch endpoint

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

efdde64c23 [#110 ] tree: Add more logs for switching tree endpoints

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

dkirillov requested review from storage-services-committers 2023-05-19 14:12:28 +00:00

dkirillov requested review from storage-services-developers 2023-05-19 14:12:28 +00:00

dkirillov force-pushed bugfix/110-update_tree_switching_condition from d8d436392d to 7edd827706

2023-05-19 14:24:20 +00:00

Compare

dkirillov referenced this pull request

2023-05-19 14:25:31 +00:00

(master) Improve tree node switching #116

alexvanin approved these changes 2023-05-22 08:08:36 +00:00

alexvanin left a comment

LGTM

internal/frostfs/services/tree_client_grpc.go

													
				@ -183,2 +188,4 @@

					}

					log := c.log.With(zap.String("request_id", api.GetRequestID(ctx)), zap.String("tree", treeID),

						zap.String("method", "GetSubTree"))

alexvanin commented

2023-05-22 08:00:11 +00:00

I don't really like an idea of passing log object down to execution stack. I prefer storing required data in the context, like request_id.

Keep it this way in this PR, but let's discuss it further in #111.

I don't really like an idea of passing log object down to execution stack. I prefer storing required data in the context, like `request_id`. Keep it this way in this PR, but let's discuss it further in #111.