TrueCloudLab
/
frostfs-s3-gw
15
2
Fork 15
Code Issues 20 Pull Requests 6 Actions Packages Projects Releases 7 Activity

[#135] Support GSet for credentials #130

Merged
alexvanin merged 1 commits from dkirillov/frostfs-s3-gw:poc/creds-2pset into master 2023-07-26 21:08:01 +00:00
Conversation 0 Commits 1 Files Changed 2
dkirillov commented 2023-06-06 16:00:30 +00:00
Collaborator

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

close #135

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com> close #135
dkirillov self-assigned this 2023-06-06 16:00:30 +00:00
dkirillov force-pushed poc/creds-2pset from b0b35daaf6 to 52cdaec798 2023-06-08 11:27:42 +00:00 Compare
dkirillov force-pushed poc/creds-2pset from 52cdaec798 to e2fd019e03 2023-06-13 09:39:41 +00:00 Compare
dkirillov changed title from WIP: [#XX] Poc creds 2pset to WIP: [#135] Support GSet for credentials 2023-06-13 09:40:16 +00:00
dkirillov changed title from WIP: [#135] Support GSet for credentials to [#XX] Poc creds 2pset 2023-06-13 09:40:19 +00:00
dkirillov changed title from [#XX] Poc creds 2pset to [#XX] Poc creds 2pset 2023-06-13 09:40:22 +00:00
dkirillov requested review from realloc 2023-06-13 09:40:37 +00:00
dkirillov requested review from storage-services-committers 2023-06-13 09:40:38 +00:00
dkirillov requested review from storage-services-developers 2023-06-13 09:40:39 +00:00
dkirillov changed title from [#XX] Poc creds 2pset to [#135] Poc creds 2pset 2023-06-13 09:40:54 +00:00
pogpp approved these changes 2023-06-13 10:47:47 +00:00
dkirillov changed title from [#135] Poc creds 2pset to [#135] Support GSet for credentials 2023-06-13 12:20:46 +00:00
alexvanin reviewed 2023-06-14 11:09:42 +00:00
internal/frostfs/crdt/gset.go Outdated
@ -0,0 +77,4 @@
return headers
}
func (v *ObjectVersions) GetLast() *ObjectVersion {
alexvanin commented 2023-06-14 11:08:06 +00:00
Owner

Maybe some tests for sorting and getting last versions will be suitable there.

Maybe some tests for sorting and getting last versions will be suitable there.
👍 1
alexvanin reviewed 2023-06-14 11:36:59 +00:00
cmd/s3-authmate/main.go Outdated
@ -232,0 +237,4 @@
Usage: "access key id for s3 (use this flag to update existing creds, if this flag is provided '--container-id', '--container-friendly-name' and '--container-placement-policy' are ineffective)",
Required: false,
Destination: &accessKeyIDFlag,
},
alexvanin commented 2023-06-14 11:36:59 +00:00
Owner

Did you consider having separate command like authmate re-issue-secret or update-secret? It will be a bit more intuitive, I think. For instance issue-secret expects user's wallet to produce credits while update-secret expects gate wallet to do re-sign. We can describe it in flag description in separate commands.

Did you consider having separate command like `authmate re-issue-secret` or `update-secret`? It will be a bit more intuitive, I think. For instance `issue-secret` expects user's wallet to produce credits while `update-secret` expects gate wallet to do re-sign. We can describe it in flag description in separate commands.
dkirillov commented 2023-06-15 08:59:32 +00:00
Poster
Collaborator

I considered this but decided that having separate command leads to refactoring (due to code duplication) and this refactor tends to be quite comprehensive #131

I considered this but decided that having separate command leads to refactoring (due to code duplication) and this refactor tends to be quite comprehensive #131
👍 1
alexvanin marked this conversation as resolved
dkirillov force-pushed poc/creds-2pset from e2fd019e03 to 654b2193b8 2023-06-16 06:38:54 +00:00 Compare
dkirillov force-pushed poc/creds-2pset from 654b2193b8 to dfc4476afd 2023-06-16 06:43:27 +00:00 Compare
ironbee approved these changes 2023-06-16 07:59:41 +00:00
alexvanin approved these changes 2023-06-19 10:14:56 +00:00
alexvanin merged commit dfc4476afd into master 2023-06-19 10:15:04 +00:00
alexvanin deleted branch poc/creds-2pset 2023-06-19 10:15:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
realloc
pogpp
ironbee
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dkirillov
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#130
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:poc/creds-2pset"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?