TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

authmate: Refactor using cobra #131

New issue
Closed
opened 2023-06-07 06:53:44 +00:00 by dkirillov · 1 comment
dkirillov commented 2023-06-07 06:53:44 +00:00
Member
Copy link

It's getting harder to maintain and extend authmate command line tool. Now it's in just one file and use https://github.com/urfave/cli. Probably it isn't the best choice, especially if we want to introduce sub commands (e.g. one to interact with cred, another to interact with presigned urls).

Suggestion:
Make some refactor and start using https://github.com/spf13/cobra

It's getting harder to maintain and extend authmate command line tool. Now it's in just [one file](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/acb6e8cbcae7e2b3c894c8a160088655f8b26642/cmd/s3-authmate/main.go) and use https://github.com/urfave/cli. Probably it isn't the best choice, especially if we want to introduce sub commands (e.g. one to interact with cred, another to interact with presigned urls). Suggestion: Make some refactor and start using https://github.com/spf13/cobra
👍 2
alexvanin commented 2023-06-07 11:46:08 +00:00
Owner
Copy link

I think we can do this without breaking command line interface compatibility.

I think we can do this without breaking command line interface compatibility.
alexvanin added this to the v0.28.0 milestone 2023-06-15 11:38:29 +00:00
dkirillov self-assigned this 2023-06-22 07:47:17 +00:00
alexvanin referenced this issue from a commit 2023-06-27 11:39:32 +00:00
[#131] Update docs
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.31
support/v0.30
support/v0.29
support/v0.28
support/v0.27
v0.32.0
v0.31.3
v0.31.2
v0.30.9
v0.31.1
v0.31.0
v0.31.0-rc.6
v0.31.0-rc.5
v0.31.0-rc.4
v0.30.8
v0.31.0-rc.3
v0.30.7
v0.31.0-rc.2
v0.31.0-rc.1
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.30.0-rc.5
v0.29.2
v0.30.0-rc.4
v0.30.0-rc.3
v0.30.0-rc.2
v0.29.1
v0.30.0-rc.1
v0.29.0
v0.28.2
v0.29.0-rc.11
v0.29.0-rc.10
v0.29.0-rc.9
v0.29.0-rc.8
v0.29.0-rc.7
v0.29.0-rc.6
v0.29.0-rc.5
v0.29.0-rc.4
v0.29.0-rc.3
v0.29.0-rc.2
v0.29.0-rc.1
v0.28.1
v0.28.0
v0.28.0-rc.1
v0.27.0
v0.27.0-rc.2
v0.27.0-rc.1
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.28.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#131
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?