authmate: Refactor using cobra #131

New Issue

Closed

opened 2023-06-07 06:53:44 +00:00 by dkirillov · 1 comment

dkirillov commented

2023-06-07 06:53:44 +00:00

Collaborator

It's getting harder to maintain and extend authmate command line tool. Now it's in just one file and use https://github.com/urfave/cli. Probably it isn't the best choice, especially if we want to introduce sub commands (e.g. one to interact with cred, another to interact with presigned urls).

Suggestion:
Make some refactor and start using https://github.com/spf13/cobra

It's getting harder to maintain and extend authmate command line tool. Now it's in just [one file](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/acb6e8cbcae7e2b3c894c8a160088655f8b26642/cmd/s3-authmate/main.go) and use https://github.com/urfave/cli. Probably it isn't the best choice, especially if we want to introduce sub commands (e.g. one to interact with cred, another to interact with presigned urls). Suggestion: Make some refactor and start using https://github.com/spf13/cobra

alexvanin commented

2023-06-07 11:46:08 +00:00

Owner

I think we can do this without breaking command line interface compatibility.

I think we can do this without breaking command line interface compatibility.

dkirillov referenced this issue

2023-06-15 08:59:32 +00:00

[#135] Support GSet for credentials #130

alexvanin added this to the v0.28.0 milestone 2023-06-15 11:38:29 +00:00

dkirillov self-assigned this 2023-06-22 07:47:17 +00:00

dkirillov referenced a pull request that will close this issue

2023-06-23 13:36:14 +00:00

feature/131-authmate_refactor #151

alexvanin closed this issue

2023-06-27 11:39:31 +00:00

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] Fix session token limit by container

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Add agent.UpdateSecret

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Make authmate use cobra

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Add issue-secret cobra cmd

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Add obtain-secret corba cmd

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Add generate-presigned-url cobra cmd

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] authmate: Add update-secret cobra cmd

alexvanin referenced this issue from a commit

2023-06-27 11:39:32 +00:00

[#131] Update docs

Sign in to join this conversation.

No Label

good first issue

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#131

There is no content yet.