feature/131-authmate_refactor #151

dkirillov · 2023-06-23T13:36:14Z

dkirillov commented

2023-06-23 13:36:14 +00:00

close #131

dkirillov self-assigned this 2023-06-23 13:36:14 +00:00

dkirillov referenced this pull request

2023-06-23 13:41:10 +00:00

authmate: Use different exit codes #152

dkirillov force-pushed feature/131-authmate_refactor from cde29b87b3 to 14f58b05b4

2023-06-23 13:53:48 +00:00

Compare

dkirillov changed title from ~~WIP: feature/131-authmate_refactor~~ to feature/131-authmate_refactor

2023-06-26 06:19:07 +00:00

dkirillov requested review from storage-services-developers 2023-06-26 06:19:16 +00:00

dkirillov requested review from storage-services-committers 2023-06-26 06:19:16 +00:00

alexvanin approved these changes 2023-06-27 10:56:55 +00:00

authmate/authmate.go Outdated

					
				@ -138,3 +154,3 @@

					issuingResult struct {

						AccessKeyID        string `json:"access_key_id"`

						InitialAccessKeyID string `json:"initial_access_key_id"`

						AccessKeyID        string `json:"access_key_id"`

alexvanin commented

2023-06-27 10:54:49 +00:00

Why though? 😄

dkirillov commented

2023-06-27 11:17:57 +00:00

It seems more logical to me to see the initial credentials first

alexvanin marked this conversation as resolved

cmd/s3-authmate/modules/obtain-secret.go Outdated

					
				@ -0,0 +68,4 @@

					}

					poolCfg := PoolConfig{

						Key:                &key.PrivateKey,

alexvanin commented

2023-06-27 10:47:55 +00:00

What you think about using a gateway private key there? Is there a case when we need to use different keys to obtain and decode box?

We can discuss it in separate issue if you want.

What you think about using a gateway private key there? Is there a case when we need to use different keys to obtain and decode box? We can discuss it in separate issue if you want.

dkirillov commented

2023-06-27 11:16:10 +00:00

In general we need both.
Let's say we create private container, so to access any object we need key of container owher. It's erroneous corner case though (s3 keys should always have read access to the container, but we cannot guarantee this)

In general we need both. Let's say we create private container, so to access any object we need key of container owher. It's erroneous corner case though (s3 keys should always have read access to the container, but we cannot guarantee this)

👍 1