Check `Content-Encoding` header in chunked payload based on kludge flag #146

New issue

Closed

opened 2023-06-21 08:24:38 +00:00 by alexvanin · 1 comment

alexvanin commented

2023-06-21 08:24:38 +00:00

Owner

In #126 gateway uses chunk payload reader if request contains X-Amz-Content-Sha256 header with STREAMING-AWS4-HMAC-SHA256-PAYLOAD value. However specification also mentions Content-Encoding header with aws-chunked value. However not all clients set this header, e.g. minio-go client.

Describe the solution you'd like

Add a new flag to kludge config section: ignore_content_encoding_in_chunks. If it is set, then ignore Content-Encoding header in chunk payloads. Otherwise check it and return error if it is missing.

Describe alternatives you've considered

None.

Additional context

None.

## Is your feature request related to a problem? Please describe. In #126 gateway uses chunk payload reader if request contains `X-Amz-Content-Sha256` header with `STREAMING-AWS4-HMAC-SHA256-PAYLOAD` value. However specification also [mentions](https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html) `Content-Encoding` header with `aws-chunked` value. However not all clients set this header, e.g. minio-go client. ## Describe the solution you'd like Add a new flag to `kludge` config section: `ignore_content_encoding_in_chunks`. If it is set, then ignore `Content-Encoding` header in chunk payloads. Otherwise check it and return error if it is missing. ## Describe alternatives you've considered None. ## Additional context None.

alexvanin referenced this issue

2023-06-21 08:29:25 +00:00

Use kludge profiles based on user-agent #147

dkirillov commented

2023-06-21 08:37:53 +00:00

Member

If it is set, then ignore Content-Encoding

Actually, we should bypass this header without aws-chuncked but still eliminate this value from header, because it can contains several values and we should preserve user-defined values. see https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html

> If it is set, then ignore Content-Encoding Actually, we should bypass this header without `aws-chuncked` but still eliminate this value from header, because it can contains several values and we should preserve user-defined values. see https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html

👍 1