Check Content-Encoding
header in chunked payload based on kludge flag #146
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-s3-gw#146
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is your feature request related to a problem? Please describe.
In #126 gateway uses chunk payload reader if request contains
X-Amz-Content-Sha256
header withSTREAMING-AWS4-HMAC-SHA256-PAYLOAD
value. However specification also mentionsContent-Encoding
header withaws-chunked
value. However not all clients set this header, e.g. minio-go client.Describe the solution you'd like
Add a new flag to
kludge
config section:ignore_content_encoding_in_chunks
. If it is set, then ignoreContent-Encoding
header in chunk payloads. Otherwise check it and return error if it is missing.Describe alternatives you've considered
None.
Additional context
None.
Actually, we should bypass this header without
aws-chuncked
but still eliminate this value from header, because it can contains several values and we should preserve user-defined values. see https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html