TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

feature/146-add_flag_to_check_content-encoding_in_chunked_payload #167

Merged
alexvanin merged 1 commits from dkirillov/frostfs-s3-gw:feature/146-add_flag_to_check_content-encoding_in_chunked_payload into master 2023-07-26 21:08:01 +00:00
Conversation 0 Commits 1 Files Changed 12
dkirillov commented 2023-07-10 11:47:06 +00:00
Collaborator

close #146

close #146
dkirillov self-assigned this 2023-07-10 11:47:06 +00:00
dkirillov requested review from storage-services-developers 2023-07-10 11:48:25 +00:00
dkirillov requested review from storage-services-committers 2023-07-10 11:48:25 +00:00
alexvanin added this to the v0.28.0 milestone 2023-07-12 09:44:15 +00:00
dkirillov force-pushed feature/146-add_flag_to_check_content-encoding_in_chunked_payload from 8071536392 to 0bd3a1244d 2023-07-14 12:36:50 +00:00 Compare
ironbee approved these changes 2023-07-14 12:58:53 +00:00
alexvanin reviewed 2023-07-18 10:09:21 +00:00
cmd/s3-gw/app.go Outdated
@ -70,2 +70,4 @@
xmlDecoder *xml.DecoderProvider
maxClient maxClientsConfig
mu sync.RWMutex
alexvanin commented 2023-07-18 10:09:21 +00:00
Owner

Don't you think it is a bit weird to define mutex for single bypassContentEncodingInChunks? Other settings use embedded mutex e.g. placementPolicy.

Can we use atomic bool here instead?

Don't you think it is a bit weird to define mutex for single `bypassContentEncodingInChunks`? Other settings use embedded mutex e.g. `placementPolicy`. Can we use atomic bool here instead?
dkirillov commented 2023-07-18 10:16:24 +00:00
Poster
Collaborator

I'll fix it

I'll fix it
dkirillov force-pushed feature/146-add_flag_to_check_content-encoding_in_chunked_payload from 0bd3a1244d to 6091efed14 2023-07-18 10:30:15 +00:00 Compare
alexvanin approved these changes 2023-07-18 11:47:29 +00:00
dkirillov force-pushed feature/146-add_flag_to_check_content-encoding_in_chunked_payload from 6091efed14 to b59aa06637 2023-07-18 11:50:29 +00:00 Compare
alexvanin merged commit b59aa06637 into master 2023-07-18 12:02:38 +00:00
alexvanin deleted branch feature/146-add_flag_to_check_content-encoding_in_chunked_payload 2023-07-18 12:02:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ironbee
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.28.0
Assignees
Clear assignees
No Assignees
dkirillov
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#167
There is no content yet.
Delete Branch "dkirillov/frostfs-s3-gw:feature/146-add_flag_to_check_content-encoding_in_chunked_payload"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?