Don't return 200 code when object body is not found #158

New issue

Closed

opened 2023-06-30 07:33:40 +00:00 by dkirillov · 1 comment

dkirillov commented

2023-06-30 07:33:40 +00:00

Member

As mentioned in #156 we get 200 http code because of writing header before reading object from FrostFS (if object id exists in the cache but not in storage we get 200 code and error in body)

Expected Behavior

Get 404 status if object not found even when cache contains object header

Current Behavior

We get 200 OK but the body right away contains NoSuchKey error

Possible Solution

Probably we can write status code header right after init reading

Steps to Reproduce (for bugs)


func TestGetObject(t *testing.T) {
	hc := prepareHandlerContext(t)
	bktName, objName := "bucket", "obj"
	bktInfo, objInfo := createVersionedBucketAndObject(hc.t, hc, bktName, objName)

	putObject(hc.t, hc, bktName, objName)

	checkFound(hc.t, hc, bktName, objName, objInfo.VersionID())
	checkFound(hc.t, hc, bktName, objName, emptyVersion)

	addr := getAddressOfLastVersion(hc, bktInfo, objName)
	hc.tp.SetObjectError(addr, apistatus.ObjectNotFound{})
	hc.tp.SetObjectError(objInfo.Address(), apistatus.ObjectNotFound{})

	getObjectAssertS3Error(hc, bktName, objName, objInfo.VersionID(), s3errors.ErrNoSuchVersion) // the 'getObjectAssertS3Error' similar to 'headObjectAssertS3Error'
	getObjectAssertS3Error(hc, bktName, objName, emptyVersion, s3errors.ErrNoSuchKey)
}

Your Environment

Version used: v0.27.0-rc.1-69-g2cbe3b9a

As mentioned in #156 we get `200` http code because of [writing header before reading object from](https://git.frostfs.info/dkirillov/frostfs-s3-gw/src/commit/1587180b9e2f013aad98d17ebeffb895887dcc03/api/handler/get.go#L204-L209) FrostFS (if object id exists in the cache but not in storage we get 200 code and error in body) ## Expected Behavior Get 404 status if `object not found` even when cache contains object header ## Current Behavior We get 200 OK but the body right away contains `NoSuchKey` error ## Possible Solution Probably we can write status code header right after [init reading](https://git.frostfs.info/dkirillov/frostfs-s3-gw/src/commit/1587180b9e2f013aad98d17ebeffb895887dcc03/api/layer/layer.go#L422-L425) ## Steps to Reproduce (for bugs)   ```golang func TestGetObject(t *testing.T) { hc := prepareHandlerContext(t) bktName, objName := "bucket", "obj" bktInfo, objInfo := createVersionedBucketAndObject(hc.t, hc, bktName, objName) putObject(hc.t, hc, bktName, objName) checkFound(hc.t, hc, bktName, objName, objInfo.VersionID()) checkFound(hc.t, hc, bktName, objName, emptyVersion) addr := getAddressOfLastVersion(hc, bktInfo, objName) hc.tp.SetObjectError(addr, apistatus.ObjectNotFound{}) hc.tp.SetObjectError(objInfo.Address(), apistatus.ObjectNotFound{}) getObjectAssertS3Error(hc, bktName, objName, objInfo.VersionID(), s3errors.ErrNoSuchVersion) // the 'getObjectAssertS3Error' similar to 'headObjectAssertS3Error' getObjectAssertS3Error(hc, bktName, objName, emptyVersion, s3errors.ErrNoSuchKey) } ``` ## Your Environment  * Version used: v0.27.0-rc.1-69-g2cbe3b9a