TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

[#158] Separate init object reader from read itself #164

Merged
dkirillov merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/158-return_404_if_object_not_found_but_cache_contains_meta into master 2023-07-12 09:27:08 +00:00
Conversation 0 Commits 1 Files changed 10 +182 -84
dkirillov commented 2023-07-06 13:45:18 +00:00
Member
Copy link

To be able to handle cases and return appropriate http status code
when object missed in storage but gate cache contains its metadata
we need write code after init object reader.
So we separate init reader from actual reading.

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

To be able to handle cases and return appropriate http status code when object missed in storage but gate cache contains its metadata we need write code after init object reader. So we separate init reader from actual reading. Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-07-06 13:45:18 +00:00
dkirillov force-pushed bugfix/158-return_404_if_object_not_found_but_cache_contains_meta from 6e537f14dd to 1979f3db15 2023-07-06 13:46:32 +00:00 Compare
dkirillov requested review from storage-services-developers 2023-07-07 06:28:00 +00:00
dkirillov requested review from storage-services-committers 2023-07-07 06:28:01 +00:00
dkirillov force-pushed bugfix/158-return_404_if_object_not_found_but_cache_contains_meta from 1979f3db15 to 8fd2ab6169 2023-07-11 14:12:48 +00:00 Compare
dkirillov force-pushed bugfix/158-return_404_if_object_not_found_but_cache_contains_meta from 8fd2ab6169 to 14ef9ff091 2023-07-11 14:33:02 +00:00 Compare
alexvanin approved these changes 2023-07-11 15:19:54 +00:00
ironbee approved these changes 2023-07-12 07:40:03 +00:00
pogpp approved these changes 2023-07-12 08:21:21 +00:00
dkirillov merged commit 14ef9ff091 into master 2023-07-12 09:27:08 +00:00
dkirillov deleted branch bugfix/158-return_404_if_object_not_found_but_cache_contains_meta 2023-07-12 09:27:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
ironbee
pogpp
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#164
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/158-return_404_if_object_not_found_but_cache_contains_meta"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?