TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

[#166] Update sdk to support grpc schemes in tree pool #166

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/update_sdk_to_support_schemes_in_tree_pool into master 2023-07-10 13:12:48 +00:00
Conversation 0 Commits 1 Files changed 3 +7 -8
dkirillov commented 2023-07-07 13:41:26 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-07-07 13:41:26 +00:00
dkirillov added 1 commit 2023-07-07 13:41:30 +00:00
[#XX] Update sdk to support grpc schemes in tree pool
All checks were successful
/ DCO (pull_request) Successful in 1m16s
Details
/ Vulncheck (pull_request) Successful in 1m55s
Details
/ Builds (1.19) (pull_request) Successful in 3m17s
Details
/ Builds (1.20) (pull_request) Successful in 2m46s
Details
/ Lint (pull_request) Successful in 3m44s
Details
/ Tests (1.19) (pull_request) Successful in 9m3s
Details
/ Tests (1.20) (pull_request) Successful in 10m24s
Details
916b7d8a9f 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] Update sdk to support grpc schemes in tree pool to WIP: [#166] Update sdk to support grpc schemes in tree pool 2023-07-07 13:42:42 +00:00
dkirillov changed title from WIP: [#166] Update sdk to support grpc schemes in tree pool to [#166] Update sdk to support grpc schemes in tree pool 2023-07-07 13:42:55 +00:00
dkirillov requested review from storage-services-developers 2023-07-07 13:43:04 +00:00
dkirillov requested review from storage-services-committers 2023-07-07 13:43:04 +00:00
pogpp approved these changes 2023-07-07 13:47:41 +00:00
alexvanin reviewed 2023-07-10 11:46:36 +00:00
cmd/s3-gw/app.go
@ -314,3 +313,3 @@
var apiGRPCDialOpts []grpc.DialOption
var treeGRPCDialOpts = []grpc.DialOption{grpc.WithTransportCredentials(insecure.NewCredentials())}
var treeGRPCDialOpts []grpc.DialOption
alexvanin commented 2023-07-07 14:24:15 +00:00
Owner
Copy link

Should we merge tree and api opts until they going to have a difference or keep it?
I am okay with both options.

Should we merge tree and api opts until they going to have a difference or keep it? I am okay with both options.
dkirillov commented 2023-07-10 11:49:51 +00:00
Author
Member
Copy link

I thought about it, but decided to make less changes in PR

I thought about it, but decided to make less changes in PR
alexvanin approved these changes 2023-07-10 13:12:40 +00:00
alexvanin merged commit 916b7d8a9f into master 2023-07-10 13:12:48 +00:00
alexvanin deleted branch feature/update_sdk_to_support_schemes_in_tree_pool 2023-07-10 13:12:48 +00:00
alexvanin added this to the v0.28.0 milestone 2023-07-12 09:42:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.28.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#166
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/update_sdk_to_support_schemes_in_tree_pool"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?