[#180] Fix linter issues #191

Merged
dkirillov merged 1 commit from mbiryukova/frostfs-s3-gw:feature/fix_linter_issues into master 2023-08-22 08:02:40 +00:00
Member

Closes #180

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #180 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2023-08-21 09:21:43 +00:00
mbiryukova requested review from storage-services-developers 2023-08-21 09:21:44 +00:00
dkirillov reviewed 2023-08-21 09:21:47 +00:00
@ -200,3 +195,3 @@
if token != nil {
prm.SetSessionToken(*token)
prm.Session = token
Member

It seems we can now skip checking if token != nil

It seems we can now skip checking `if token != nil`
dkirillov marked this conversation as resolved
Member

Maybe we should update SDK in this PR because of TrueCloudLab/frostfs-sdk-go#148

I'm not sure if we can wait until TrueCloudLab/frostfs-sdk-go#121 be done to fix the same issues at once

Maybe we should update SDK in this PR because of https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/148 I'm not sure if we can wait until https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/121 be done to fix the same issues at once
mbiryukova force-pushed feature/fix_linter_issues from 8f7a8180c6 to 7c2f44ba9f 2023-08-21 09:29:15 +00:00 Compare
mbiryukova force-pushed feature/fix_linter_issues from 7c2f44ba9f to 765c992f12 2023-08-21 11:08:22 +00:00 Compare
dkirillov approved these changes 2023-08-21 11:15:45 +00:00
mbiryukova self-assigned this 2023-08-21 11:17:32 +00:00
Owner

I suggest to merge it and fix all deprecated warnings on every SDK update, though. Seems like fix is quite simple to implement.

I suggest to merge it and fix all `deprecated` warnings on every SDK update, though. Seems like fix is quite simple to implement.
Owner

And yes, let's update SDK in this PR too with more deprecated warnings to fix. @mbiryukova

And yes, let's update SDK in this PR too with more `deprecated` warnings to fix. @mbiryukova
mbiryukova force-pushed feature/fix_linter_issues from 765c992f12 to 012ece40bb 2023-08-21 14:25:02 +00:00 Compare
dkirillov approved these changes 2023-08-21 14:33:01 +00:00
alexvanin approved these changes 2023-08-22 07:45:13 +00:00
dkirillov merged commit 012ece40bb into master 2023-08-22 08:02:40 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#191
No description provided.