TrueCloudLab
/
frostfs-s3-gw
15
2
Fork 14
Code Issues 19 Pull Requests 5 Actions Packages Releases 6 Activity

[#180] Fix linter issues #191

Merged
dkirillov merged 1 commits from mbiryukova/frostfs-s3-gw:feature/fix_linter_issues into master 2023-08-22 08:02:40 +00:00
Conversation 3 Commits 1 Files Changed 3
mbiryukova commented 2023-08-21 09:13:27 +00:00
Collaborator

Closes #180

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #180 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2023-08-21 09:21:43 +00:00
mbiryukova requested review from storage-services-developers 2023-08-21 09:21:44 +00:00
dkirillov reviewed 2023-08-21 09:21:47 +00:00
internal/frostfs/frostfs.go Outdated
@ -200,3 +195,3 @@
if token != nil {
prm.SetSessionToken(*token)
prm.Session = token
dkirillov commented 2023-08-21 09:21:47 +00:00
Collaborator

It seems we can now skip checking if token != nil

It seems we can now skip checking `if token != nil`
dkirillov marked this conversation as resolved
dkirillov commented 2023-08-21 09:23:51 +00:00
Collaborator

Maybe we should update SDK in this PR because of TrueCloudLab/frostfs-sdk-go#148

I'm not sure if we can wait until TrueCloudLab/frostfs-sdk-go#121 be done to fix the same issues at once

Maybe we should update SDK in this PR because of https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/148 I'm not sure if we can wait until https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/121 be done to fix the same issues at once
mbiryukova force-pushed feature/fix_linter_issues from 8f7a8180c6 to 7c2f44ba9f 2023-08-21 09:29:15 +00:00 Compare
mbiryukova force-pushed feature/fix_linter_issues from 7c2f44ba9f to 765c992f12 2023-08-21 11:08:22 +00:00 Compare
dkirillov approved these changes 2023-08-21 11:15:45 +00:00
mbiryukova self-assigned this 2023-08-21 11:17:32 +00:00
alexvanin commented 2023-08-21 11:51:14 +00:00
Owner

I suggest to merge it and fix all deprecated warnings on every SDK update, though. Seems like fix is quite simple to implement.

I suggest to merge it and fix all `deprecated` warnings on every SDK update, though. Seems like fix is quite simple to implement.
alexvanin commented 2023-08-21 11:52:06 +00:00
Owner

And yes, let's update SDK in this PR too with more deprecated warnings to fix. @mbiryukova

And yes, let's update SDK in this PR too with more `deprecated` warnings to fix. @mbiryukova
mbiryukova force-pushed feature/fix_linter_issues from 765c992f12 to 012ece40bb 2023-08-21 14:25:02 +00:00 Compare
dkirillov approved these changes 2023-08-21 14:33:01 +00:00
alexvanin approved these changes 2023-08-22 07:45:13 +00:00
dkirillov merged commit 012ece40bb into master 2023-08-22 08:02:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
mbiryukova
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#191
There is no content yet.
Delete Branch "mbiryukova/frostfs-s3-gw:feature/fix_linter_issues"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?