Expand xmlns field ignore #221

New issue

Closed

opened 2023-09-28 12:38:47 +00:00 by alexvanin · 1 comment

alexvanin commented

2023-09-28 12:38:47 +00:00

Owner

In #40 S3 Gateway introduced new kludge.use_default_xmlns_for_complete_multipart flag to ignore xmlns field in multipart. Turns out, there are plenty more requests without xmlns field in libraries like minio-go and minio-js:

versioning configuration
put object retention
put object legal hold
put object tagging
put bucket object lock config

Describe the solution you'd like

Add more generic kludge flag to enable and disable all these xmlns checks.

## Is your feature request related to a problem? Please describe. In #40 S3 Gateway introduced new `kludge.use_default_xmlns_for_complete_multipart` flag to ignore xmlns field in multipart. Turns out, there are plenty more requests without xmlns field in libraries like minio-go and minio-js: - versioning configuration - put object retention - put object legal hold - put object tagging - put bucket object lock config ## Describe the solution you'd like Add more generic `kludge` flag to enable and disable all these xmlns checks.

alexvanin added this to the v0.29.0 milestone 2023-09-28 12:38:47 +00:00

mbiryukova self-assigned this 2023-10-09 10:33:34 +00:00

mbiryukova referenced this issue from a pull request that will close it,

2023-10-09 13:36:18 +00:00

[#221] Expand xmlns field ignore #235

dkirillov commented

2023-10-10 07:34:37 +00:00

Member

Turns out, there are plenty more requests without xmlns field in libraries like minio-go and minio-js:

versioning configuration

put object retention

put object legal hold

put object tagging

put bucket object lock config

I would suggest extending this new flag to all requests rather than just for a little subset. This makes the code more consistent and it seems there is not downside of such solution. Otherwise, there is a possibility that we will encounter a similar problem for other queries in the future.

> Turns out, there are plenty more requests without xmlns field in libraries like minio-go and minio-js: > - versioning configuration > - put object retention > - put object legal hold > - put object tagging > - put bucket object lock config I would suggest extending this new flag to all requests rather than just for a little subset. This makes the code more consistent and it seems there is not downside of such solution. Otherwise, there is a possibility that we will encounter a similar problem for other queries in the future.

alexvanin closed this issue

2023-10-17 14:39:30 +00:00

alexvanin referenced this issue from a commit

2023-10-17 14:39:32 +00:00

[#221] Expand xmlns field ignore

alexvanin modified the milestone from v0.29.0 to v0.28.0

2024-05-27 10:29:20 +00:00

alexvanin modified the milestone from v0.28.0 to v0.29.0

2024-05-27 10:44:30 +00:00