TrueCloudLab
/
frostfs-s3-gw
16
2
Fork 14
Code Issues 19 Pull Requests 4 Actions Packages Releases 6 Activity

[#221] Expand xmlns field ignore #235

Merged
alexvanin merged 1 commits from mbiryukova/frostfs-s3-gw:feature/expand_xmlns_field_ignore into master 2023-10-17 14:39:30 +00:00
Conversation 0 Commits 1 Files Changed 22
mbiryukova commented 2023-10-09 13:36:18 +00:00
Collaborator

Closes #221

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #221 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2023-10-09 13:36:18 +00:00
mbiryukova requested review from storage-services-committers 2023-10-09 13:47:56 +00:00
mbiryukova requested review from storage-services-developers 2023-10-09 13:47:57 +00:00
mbiryukova force-pushed feature/expand_xmlns_field_ignore from b0ef9f2648 to 0c3c5857de 2023-10-10 10:26:37 +00:00 Compare
mbiryukova force-pushed feature/expand_xmlns_field_ignore from 0c3c5857de to 356001b38f 2023-10-10 10:31:18 +00:00 Compare
dkirillov approved these changes 2023-10-13 08:19:52 +00:00
dkirillov left a comment
Collaborator

Please, update CHANGELOG.md. And rebase the branch

Please, update CHANGELOG.md. And rebase the branch
api/handler/api.go Outdated
@ -36,3 +36,3 @@
CopiesNumbers(string) ([]uint32, bool)
DefaultCopiesNumbers() []uint32
NewCompleteMultipartDecoder(io.Reader) *xml.Decoder
NewXMLDecoderOrDefault(io.Reader) *xml.Decoder
dkirillov commented 2023-10-13 08:14:57 +00:00
Collaborator

Maybe can name this just NewXmlDecoder?

Maybe can name this just `NewXmlDecoder`?
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/expand_xmlns_field_ignore from 356001b38f to fb90f56b3c 2023-10-13 10:19:17 +00:00 Compare
dkirillov reviewed 2023-10-13 13:09:54 +00:00
CHANGELOG.md Outdated
@ -45,6 +45,7 @@ This document outlines major changes between releases.
- Complete multipart upload doesn't unnecessary copy now. Thus, the total time of multipart upload was reduced by 2 times (#63)
- Use gate key to form object owner (#175)
- Apply placement policies and copies if there is at least one valid value (#168)
- Generalise config param to use default xmlns for all requests (#221)
dkirillov commented 2023-10-13 13:09:54 +00:00
Collaborator

It would be nice to mention exact config param name that now is not supported and which one must be used instead

It would be nice to mention exact config param name that now is not supported and which one must be used instead
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/expand_xmlns_field_ignore from fb90f56b3c to 298662df9d 2023-10-13 13:22:48 +00:00 Compare
dkirillov approved these changes 2023-10-16 06:46:32 +00:00
alexvanin approved these changes 2023-10-17 14:39:24 +00:00
alexvanin merged commit 298662df9d into master 2023-10-17 14:39:30 +00:00
alexvanin deleted branch feature/expand_xmlns_field_ignore 2023-10-17 14:39:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
mbiryukova
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#235
There is no content yet.
Delete Branch "mbiryukova/frostfs-s3-gw:feature/expand_xmlns_field_ignore"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?