TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 29 Pull requests 9 Projects Releases 33 Packages 1 Activity Actions

[#248] Correct NextVersionIDMarker in listing versions #248

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:bugfix/correct_handling_version_id_marker into master 2023-11-01 06:53:55 +00:00
Conversation 6 Commits 1 Files changed 6 +217 -9
dkirillov commented 2023-10-25 13:36:01 +00:00
Member
Copy link

Despite the spec https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectVersions.html#API_ListObjectVersions_ResponseElements
says that
"When the number of responses exceeds the value of MaxKeys,
NextVersionIdMarker specifies the first object version not returned
that satisfies the search criteria. Use this value for the
version-id-marker request parameter in a subsequent request."
the actual behavior of AWS S3 is returning NextVersionIdMarker as the last returned object version

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Despite the spec https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectVersions.html#API_ListObjectVersions_ResponseElements says that "When the number of responses exceeds the value of MaxKeys, NextVersionIdMarker specifies the first object version not returned that satisfies the search criteria. Use this value for the version-id-marker request parameter in a subsequent request." the actual behavior of AWS S3 is returning NextVersionIdMarker as the last returned object version Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-10-25 13:36:01 +00:00
dkirillov force-pushed bugfix/correct_handling_version_id_marker from 9c7843137f to 125739fbbd 2023-10-25 13:36:53 +00:00 Compare
dkirillov added the
bug
 label 2023-10-25 13:37:17 +00:00
dkirillov force-pushed bugfix/correct_handling_version_id_marker from 125739fbbd to ff57f64fd6 2023-10-25 13:38:02 +00:00 Compare
dkirillov changed title from WIP: [#XX] Correct NextVersionIDMarker in listing versions to WIP: [#248] Correct NextVersionIDMarker in listing versions 2023-10-25 13:38:18 +00:00
dkirillov changed title from WIP: [#248] Correct NextVersionIDMarker in listing versions to [#248] Correct NextVersionIDMarker in listing versions 2023-10-25 13:40:44 +00:00
requested reviews from storage-services-committers, storage-services-developers 2023-10-25 13:41:38 +00:00
dkirillov force-pushed bugfix/correct_handling_version_id_marker from ff57f64fd6 to a9130d472d 2023-10-25 13:43:03 +00:00 Compare
pogpp approved these changes 2023-10-25 14:01:44 +00:00
dkirillov force-pushed bugfix/correct_handling_version_id_marker from a9130d472d to aa5273294d 2023-10-27 07:59:41 +00:00 Compare
alexvanin commented 2023-10-31 13:44:55 +00:00
Owner
Copy link

@realloc Last time we discussed differences between S3 specification and AWS behaviour, we've decided to stick with the specification and support behaviour changes as some kludge compatibility flags. Isn't it a good example for that?

@realloc Last time we discussed differences between S3 specification and AWS behaviour, we've decided to stick with the specification and support behaviour changes as some kludge compatibility flags. Isn't it a good example for that?
alexvanin commented 2023-10-31 13:47:20 +00:00
Owner
Copy link

@dkirillov does minio behave the same?

@dkirillov does minio behave the same?
dkirillov commented 2023-10-31 14:33:02 +00:00
Author
Member
Copy link

@dkirillov does minio behave the same?

Yes, we've found this because of minio test (that pass on minio itself)

> @dkirillov does minio behave the same? Yes, we've found this because of minio test (that pass on minio itself)
👍 1
dkirillov commented 2023-10-31 14:35:15 +00:00
Author
Member
Copy link

Last time we discussed differences between S3 specification and AWS behaviour, we've decided to stick with the specification and support behaviour changes as some kludge compatibility flags. Isn't it a good example for that?

I'm not sure. What we consider as specification? Examples on page with specifications contradict definitions for parameters on the same page

> Last time we discussed differences between S3 specification and AWS behaviour, we've decided to stick with the specification and support behaviour changes as some kludge compatibility flags. Isn't it a good example for that? I'm not sure. What we consider as specification? Examples on page with specifications contradict definitions for parameters on the same page
dkirillov force-pushed bugfix/correct_handling_version_id_marker from aa5273294d to 5ee73fad6a 2023-10-31 14:36:42 +00:00 Compare
realloc commented 2023-11-01 06:45:18 +00:00
Owner
Copy link

If AWS contradicts the spec and does it the same way across all regions, then we can consider it normal behavior. If it is possible to make this an option toggled by default, then I suggest doing so.

If AWS contradicts the spec and does it the same way across all regions, then we can consider it normal behavior. If it is possible to make this an option toggled by default, then I suggest doing so.
alexvanin commented 2023-11-01 06:53:20 +00:00
Owner
Copy link

If AWS contradicts the spec and does it the same way across all regions, then we can consider it normal behavior.

Examples on page with specifications contradict definitions for parameters on the same page

All right, I suppose we consider it as expected behavior then and we do not need any kludge flags.

> If AWS contradicts the spec and does it the same way across all regions, then we can consider it normal behavior. > Examples on page with specifications contradict definitions for parameters on the same page All right, I suppose we consider it as expected behavior then and we do not need any kludge flags.
alexvanin approved these changes 2023-11-01 06:53:26 +00:00
alexvanin merged commit 5ee73fad6a into master 2023-11-01 06:53:55 +00:00
alexvanin deleted branch bugfix/correct_handling_version_id_marker 2023-11-01 06:53:55 +00:00
alexvanin added this to the v0.29.0 milestone 2024-05-27 10:20:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.29.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#248
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:bugfix/correct_handling_version_id_marker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?